-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SP-62 Feature/product taxon tabs extensibility #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tab class.
Fix url attribute definition.
Rename module. Fix lint.
Fix test setup.
main_menu and tab items.
and embed it into a tab object.
so that Section class can include this only.
in ItemManager. Delete ItemAppender module.
rafalcymerys
approved these changes
Oct 23, 2023
delete-merged-branch
bot
deleted the
feature/product-taxon-tabs-extensibility
branch
October 23, 2023 16:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
SP-62
Provide builder classes to configure tabs in a couple of resources (e.g order, product, user), administered in the admin panel.
Why?
In order for the extensions to be able to configure/extend via code, instead of using deface (external gem).
How?
Based on the approach implemented in #260