Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SP-62 Feature/product taxon tabs extensibility #274

Merged
merged 98 commits into from
Oct 23, 2023
Merged

SP-62 Feature/product taxon tabs extensibility #274

merged 98 commits into from
Oct 23, 2023

Commits on Sep 28, 2023

  1. Lay groundwork for order tabs builder

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4002e57 View commit details
    Browse the repository at this point in the history

  2. Lay groundwork for tab's root item

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9ee43d7 View commit details
    Browse the repository at this point in the history

  3. Add test for adding to root already appended item

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    b90bcb6 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary tests

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    38fa683 View commit details
    Browse the repository at this point in the history

  5. Add test for tab class. 

    Add tab class.
    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    485ee96 View commit details
    Browse the repository at this point in the history

  6. Accommodate text variable in tab class

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    cbe0e80 View commit details
    Browse the repository at this point in the history

  7. Facilitate tab url

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d0cade7 View commit details
    Browse the repository at this point in the history

  8. Add partial_name to tabs attributes

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    941d186 View commit details
    Browse the repository at this point in the history

  9. Add css classes to tab attributes

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    65de37e View commit details
    Browse the repository at this point in the history

  10. Add methods for building particular tabs

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    55abda6 View commit details
    Browse the repository at this point in the history

  11. Add Proc handling for url attribute

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8eca944 View commit details
    Browse the repository at this point in the history

  12. Facilitate check for active css class. 

    Fix url attribute definition.
    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3370768 View commit details
    Browse the repository at this point in the history

  13. Include module providing availability_check

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a27ea5e View commit details
    Browse the repository at this point in the history

  14. Initialize cart tab

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c47c921 View commit details
    Browse the repository at this point in the history

  15. Build cart tab

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9e33d66 View commit details
    Browse the repository at this point in the history

  16. Fix initialization

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    38b2f1c View commit details
    Browse the repository at this point in the history

  17. Fix - use existing attribute

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9699a26 View commit details
    Browse the repository at this point in the history

  18. Improve variable naming

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    413e034 View commit details
    Browse the repository at this point in the history

  19. Fix test setup

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2911f84 View commit details
    Browse the repository at this point in the history

  20. Fix test description

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0a8ffdd View commit details
    Browse the repository at this point in the history

  21. Add test for checking if tab is active

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    743a569 View commit details
    Browse the repository at this point in the history

  22. Add method for checking access to class index

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9c988fb View commit details
    Browse the repository at this point in the history

  23. Populate tab building steps

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5eebf1c View commit details
    Browse the repository at this point in the history

  24. Unify naming of currently selected partials

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    94b9950 View commit details
    Browse the repository at this point in the history

  25. Remove dependency on unnecessary attribute

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d6fd48c View commit details
    Browse the repository at this point in the history

  26. Cleanup test setup

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c93c192 View commit details
    Browse the repository at this point in the history

  27. Facilitate .complete? check. 

    Rename module. Fix lint.
    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    e013c04 View commit details
    Browse the repository at this point in the history

  28. Fix variable naming in root

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    059f77a View commit details
    Browse the repository at this point in the history

  29. Populate root with tabs. 

    Fix test setup.
    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a37a98b View commit details
    Browse the repository at this point in the history

  30. Fix variable naming

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d35cfff View commit details
    Browse the repository at this point in the history

  31. Lint fixes

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4563657 View commit details
    Browse the repository at this point in the history

  32. Lint fixes

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a700610 View commit details
    Browse the repository at this point in the history

  33. Build admin order_tabs upon initialization

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4833d37 View commit details
    Browse the repository at this point in the history

  34. Use order_tabs defined on boot

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2293024 View commit details
    Browse the repository at this point in the history

  35. Fix - pass correct argument

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4ac6845 View commit details
    Browse the repository at this point in the history

  36. Rename text to name

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    08018a9 View commit details
    Browse the repository at this point in the history

  37. Incorporate translators

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    e180d72 View commit details
    Browse the repository at this point in the history

  38. Use path instead of url

    @tomdonarski
    tomdonarski committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c6e0a7b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Fix appending css active class

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f1828e3 View commit details
    Browse the repository at this point in the history

  2. Migrate user tabs from view to separate class

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    6bb3ddf View commit details
    Browse the repository at this point in the history

  3. Migrate product tabs from view to separate class

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e65ea17 View commit details
    Browse the repository at this point in the history

  4. Disable variables set up in the engine

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    5cc8bc3 View commit details
    Browse the repository at this point in the history

  5. Move attributes to config. 

    Add partial_name.
    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    57af58a View commit details
    Browse the repository at this point in the history

  6. Adjust default tab builders to use config

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a60a413 View commit details
    Browse the repository at this point in the history

  7. Change back partial current attribute

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e44c65d View commit details
    Browse the repository at this point in the history

  8. Supply configs in builders with partial_name

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    5b001f1 View commit details
    Browse the repository at this point in the history

  9. Fix active check to use partial_name. 

    Fix tab spec to use config.
    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f845daf View commit details
    Browse the repository at this point in the history

  10. Enable variables set up in the engine

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    235fb56 View commit details
    Browse the repository at this point in the history

  11. Lint fix

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2e48d2e View commit details
    Browse the repository at this point in the history

  12. Lint fixes

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    7c8c182 View commit details
    Browse the repository at this point in the history

  13. Use global scope

    @tomdonarski
    tomdonarski committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    50f449e View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Refactor order_tabs_builder

    @tomdonarski
    tomdonarski committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    9ad49dd View commit details
    Browse the repository at this point in the history

  2. Refactor product_tabs_builder. 

    Refactor user_tabs_builder.
    @tomdonarski
    tomdonarski committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    109faee View commit details
    Browse the repository at this point in the history

  3. Disable class length cop

    @tomdonarski
    tomdonarski committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    3a6ad94 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Add missing data_hook attribute

    @tomdonarski
    tomdonarski committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    3fb2c43 View commit details
    Browse the repository at this point in the history

  2. Use more descriptive namespace

    @tomdonarski
    tomdonarski committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    759fce6 View commit details
    Browse the repository at this point in the history

  3. Group tabs together in the app config

    @tomdonarski
    tomdonarski committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    4ca9106 View commit details
    Browse the repository at this point in the history

  4. Embed default translation mechanism in tab

    @tomdonarski
    tomdonarski committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    1569d11 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Remove custom translations

    @tomdonarski
    tomdonarski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    5e923d8 View commit details
    Browse the repository at this point in the history

  2. Add missing .complete? checks

    @tomdonarski
    tomdonarski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    31d41c3 View commit details
    Browse the repository at this point in the history

  3. Introduce TabBuilder. 

    Split responsibilities between Tab and TabBuilder.
    @tomdonarski
    tomdonarski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    934e845 View commit details
    Browse the repository at this point in the history

  4. Fix .complete? check

    @tomdonarski
    tomdonarski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    3b36fb9 View commit details
    Browse the repository at this point in the history

  5. Lint fix

    @tomdonarski
    tomdonarski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    57e054f View commit details
    Browse the repository at this point in the history

  6. Improve formatting

    @tomdonarski
    tomdonarski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e489e1a View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary test

    @tomdonarski
    tomdonarski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6c2f96c View commit details
    Browse the repository at this point in the history

  8. Cleanup tab test

    @tomdonarski
    tomdonarski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6d34140 View commit details
    Browse the repository at this point in the history

  9. Refactor test to meet rubocop expectations

    @tomdonarski
    tomdonarski committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    94b4157 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Spell fix

    @tomdonarski
    tomdonarski committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    68026ae View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Add missing tests

    @tomdonarski
    tomdonarski committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b7903a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Adhere to naming convention in tests

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2075114 View commit details
    Browse the repository at this point in the history

  2. Cleanup - remove superfluous method

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    63e847e View commit details
    Browse the repository at this point in the history

  3. Rename an attribute

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    dbccb04 View commit details
    Browse the repository at this point in the history

  4. Fix spec after renaming an attribute

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    474be4c View commit details
    Browse the repository at this point in the history

  5. Create common abstraction for 

    main_menu and tab items.
    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    927d42f View commit details
    Browse the repository at this point in the history

  6. Add missing test

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c47e0ec View commit details
    Browse the repository at this point in the history

  7. Remove superfluous methods

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    60db052 View commit details
    Browse the repository at this point in the history

  8. Abstract away #child_with_key? method

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    4902cff View commit details
    Browse the repository at this point in the history

  9. Simplify setup

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c354d4a View commit details
    Browse the repository at this point in the history

  10. Abstract away #remove method

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    699e886 View commit details
    Browse the repository at this point in the history

  11. Abstract away #item_for_key method

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    25f6970 View commit details
    Browse the repository at this point in the history

  12. Abstract away #insert_before method

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c6d901a View commit details
    Browse the repository at this point in the history

  13. Abstract away #insert_after method

    @tomdonarski
    tomdonarski committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    af2e2fa View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Remove superfluous method

    @tomdonarski
    tomdonarski committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8430877 View commit details
    Browse the repository at this point in the history

  2. Equalize spec setup

    @tomdonarski
    tomdonarski committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    b1c9aeb View commit details
    Browse the repository at this point in the history

  3. Remove superfluous test

    @tomdonarski
    tomdonarski committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    57d6c65 View commit details
    Browse the repository at this point in the history

  4. Equalize root specs

    @tomdonarski
    tomdonarski committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    f19f5d9 View commit details
    Browse the repository at this point in the history

  5. Introduce a shared abstraction for ability checks

    @tomdonarski
    tomdonarski committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    b458feb View commit details
    Browse the repository at this point in the history

  6. Lint fix

    @tomdonarski
    tomdonarski committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    40a4e5e View commit details
    Browse the repository at this point in the history

  7. Abstract away common tests to shared examples

    @tomdonarski
    tomdonarski committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e198cb6 View commit details
    Browse the repository at this point in the history

  8. Remove tab css data from configuration, 

    and embed it into a tab object.
    @tomdonarski
    tomdonarski committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    3af140a View commit details
    Browse the repository at this point in the history

  9. Fix spec. 

    Remove comments.
    @tomdonarski
    tomdonarski committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    35a3b96 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Move 'add' method to a separate module, 

    so that Section class can include this only.
    @tomdonarski
    tomdonarski committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    0c66363 View commit details
    Browse the repository at this point in the history

  2. Split shared examples

    @tomdonarski
    tomdonarski committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    925e58d View commit details
    Browse the repository at this point in the history

  3. Include item appendage module in Root and Section

    @tomdonarski
    tomdonarski committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a7fdd65 View commit details
    Browse the repository at this point in the history

  4. Contain all item manipulation behaviour 

    in ItemManager.
Delete ItemAppender module.
    @tomdonarski
    tomdonarski committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    763aad1 View commit details
    Browse the repository at this point in the history

  5. Add back deleted method

    @tomdonarski
    tomdonarski committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c55de0a View commit details
    Browse the repository at this point in the history

  6. Add missing spec for 'add_to_section'

    @tomdonarski
    tomdonarski committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    b2e42db View commit details
    Browse the repository at this point in the history

  7. Lint fix

    @tomdonarski
    tomdonarski committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    21e4db5 View commit details
    Browse the repository at this point in the history