SP-63 Feature/improve admin actions extensibility #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdonarski
commented
Oct 9, 2023
app/models/spree/admin/actions/product_default_actions_builder.rb
Outdated
Show resolved
Hide resolved
This was referenced Oct 18, 2023
tomdonarski
force-pushed
the
feature/admin-panel-buttons-extensibility
branch
from
749b397
to
f1a2cc6
Compare
tomdonarski
commented
Oct 26, 2023
| target: action.target, | ||
| data: action.data | ||
| ) %> | ||
| <% end %> | ||
| <%= button_link_to (@deleted == '1' ? Spree.t(:show_active) : Spree.t(:show_deleted)), spree.admin_product_variants_url(@product, { q: { deleted_at_null: @deleted == '1' ? "0" : "1" } }), { class: 'btn-light', icon: 'filter.svg' } %> |
There was a problem hiding this comment.
This is the last one standing. I haven't figured out how to tackle it yet.
tomdonarski
commented
Oct 26, 2023
| { | ||
| icon_name: 'add.svg', | ||
| key: :add_product_properties, | ||
| url: 'javascript:;', |
There was a problem hiding this comment.
main. I'll take a look what the proper path would be.
tomdonarski
force-pushed
the
feature/admin-panel-buttons-extensibility
branch
from
aa83818
to
e78cd51
Compare
order actions builder, orders actions builder.
translation options as an argument
in main_menu and tabs.
Correct variable naming.
rafalcymerys
force-pushed
the
feature/admin-panel-buttons-extensibility
branch
from
97ed558
to
c1d8aeb
Compare
delete-merged-branch
bot
deleted the
feature/admin-panel-buttons-extensibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
SP-63
Provide builder classes to configure actions in a couple of resources (e.g order, product, user), administered in the admin panel.
Why?
In order for the extensions to be able to configure/extend via code, instead of using deface (external gem).
How?
Based on the approach implemented in #274