Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form content length falsify #3329

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sunhao1256
Copy link
Contributor

when disable RemoveContentLengthFilter and post form data , the form filter code chunk where contact data string exist a litter bug

i write a test case to prove the sceniaro

Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@@ -125,6 +125,7 @@ static HttpServletRequest getRequestWithBodyFromRequestParameters(HttpServletReq
Map.Entry<String, String[]> entry = entryIterator.next();
String name = entry.getKey();
List<String> values = Arrays.asList(entry.getValue());
boolean wrote = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name to valueWritten

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@sunhao1256
Copy link
Contributor Author

Please add a test

added

@spencergibb spencergibb modified the milestones: 4.1.3, 4.1.4 Apr 17, 2024
@spencergibb spencergibb removed this from the 4.1.4 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants