Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form content length falsify #3329

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Form content length falsify #3329

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0063b15
test: add DisableRemoveContentLengthFilterTests
sunhao1256 Mar 29, 2024
176a3b8
test: add DisableRemoveContentLengthFilterTests
sunhao1256 Mar 29, 2024
a44e160
fix: fix checkstyle error
sunhao1256 Mar 29, 2024
2c4e571
fix: add a boolean variable for predicating whether append "&"
sunhao1256 Mar 29, 2024
ac7f288
fix: add a boolean variable for predicating whether append "&"
sunhao1256 Mar 31, 2024
18411d9
test: replenish FormFilterTests test case
sunhao1256 Apr 6, 2024
85dc9a4
test: replenish FormFilterTests test case
sunhao1256 Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ver-mvc/src/main/java/org/springframework/cloud/gateway/server/mvc/filter/FormFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ static HttpServletRequest getRequestWithBodyFromRequestParameters(HttpServletReq
Map.Entry<String, String[]> entry = entryIterator.next();
String name = entry.getKey();
List<String> values = Arrays.asList(entry.getValue());
boolean wrote = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name to valueWritten

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

for (Iterator<String> valueIterator = values.iterator(); valueIterator.hasNext();) {
String value = valueIterator.next();
List<String> queryValues = queryParams.get(name);
Expand All @@ -139,9 +140,10 @@ static HttpServletRequest getRequestWithBodyFromRequestParameters(HttpServletReq
writer.write('&');
}
}
wrote = true;
}
}
if (entryIterator.hasNext()) {
if (wrote && entryIterator.hasNext()) {
writer.append('&');
}
}
Expand Down
Loading