Add keep-alive and inbound limits server properties #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Oct 6, 2024
...n/java/org/springframework/grpc/autoconfigure/server/DefaultServerFactoryPropertyMapper.java
Show resolved
Hide resolved
|
Seems like you might need to rebase on top of #23? |
Adds the `spring-boot-configuration-processor` to enable automatic metadata generation so our config props play well in IDEs. Also updates the default values for duration properties to use `Duration.of<Unit>(long)` instead of `Duration.of(long, DurationUnit)` as Spring Boot config processor can not determine a default for the config metadata in the latter format.
onobc
force-pushed
the
GH-6-add-server-props
branch
from
2f08483 to
03656ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: Add keep-alive and inbound limits server properties
Resolves #6
Note
I piggybacked the following feature on commit 2 (it is related and builds upon the first commit)
Commit 2: Generate metadata for config props
Adds the
spring-boot-configuration-processorto enable automatic metadatageneration so our config props play well in IDEs.
Also updates the default values for duration properties to use
Duration.of<Unit>(long)instead ofDuration.of(long, DurationUnit)asSpring Boot config processor can not determine a default for the config
metadata in the latter format.