Improve subnet overlap error message for Docker mgmt network #2845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a requested subnet overlapped with an existing Docker
network, containerlab returned Docker's raw error:
Error response from daemon: invalid pool request: Pool overlaps ...
Now, containerlab detects the overlap and returns a clearer error:
Subnet 172.20.0.0/16 already in use by Docker network "testnet".
See https://containerlab.dev/manual/network/
This helps users quickly identify the conflicting network.
list existing networks
There was a problem hiding this comment.
Pull Request Overview
This PR improves the error handling for Docker network creation when subnet overlaps occur. It replaces generic Docker daemon error messages with clear, actionable feedback that identifies which network is causing the conflict.
- Intercepts Docker's "Pool overlaps" error during management network creation
- Queries existing Docker networks to find the specific conflicting network
- Returns a user-friendly error message with documentation link
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
thanks @mgorripa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #2786
Changes
Example
Before:
Error response from daemon: invalid pool request: Pool overlaps with other one on this address space.
After:
Subnet 172.20.0.0/16 already in use by Docker network "testnet".
See https://containerlab.dev/manual/network/
This is my first contribution to containerlab.