Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions runtime/docker/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,33 @@ func (d *DockerRuntime) createMgmtBridge( //nolint: funlen

netCreateResponse, err := d.Client.NetworkCreate(nctx, d.mgmt.Network, opts)
if err != nil {
// Handle subnet overlap error
if strings.Contains(strings.ToLower(err.Error()), strings.ToLower("Pool overlaps")) ||
strings.Contains(strings.ToLower(err.Error()), strings.ToLower("subnet")) {
networksAndAddresses := map[string][]string{}
nets, _ := d.Client.NetworkList(nctx, networkapi.ListOptions{})
for _, n := range nets {
for _, cfg := range n.IPAM.Config {
// store existing networks and their subnets
networksAndAddresses[n.Name] = append(networksAndAddresses[n.Name], cfg.Subnet)
if cfg.Subnet == d.mgmt.IPv4Subnet || cfg.Subnet == d.mgmt.IPv6Subnet {
return "", fmt.Errorf(
"subnet %s already in use by Docker network %q. See https://containerlab.dev/manual/network/",
cfg.Subnet,
n.Name,
)
}
}
}
// fallback: no exact match, but clarify
return "", fmt.Errorf(
"requested subnet %s overlaps an existing Docker network. Existing networks: %v. Original error: %w. See https://containerlab.dev/manual/network/",
d.mgmt.IPv4Subnet,
networksAndAddresses,
err,
)
}

return "", err
}

Expand Down
Loading