Add initial support for closing windows with dismiss / dismissWindow
#282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaascevich
changed the title
dismissdismiss / dismissWindow
stackotter
requested changes
Dec 29, 2025
Owner
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Thanks for this! Looks great for the most part, I've just requested some documentation rewording.
Sources/SwiftCrossUI/Environment/Actions/DismissWindowAction.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftCrossUI/Environment/Actions/DismissWindowAction.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftCrossUI/Environment/Actions/DismissWindowAction.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftCrossUI/Environment/Actions/DismissWindowAction.swift
Outdated
Show resolved
Hide resolved
Owner
|
Superseded by #284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this PR only implements the
close(window:)backend method forAppKitBackend, since I have absolutely no experience with anything else. It shouldn't be too tricky for people familiar with the other backends, though.