Add required check for release build #5934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wileyj
added
chore
|
There is an order of operations bug in this PR. it should not be merged as is. moving to draft until it's addressed |
|
Fixed the order of operations issue - the github release step is required to happen before the docker build step, since the docker builds use the binaries from the github release. not ideal, but it can be addressed later - i'd like to see the github release happen as the last step in this workflow. I've added in the removal of the armv7 builds to this PR since it's a 1-line change: |
kantai
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
environemntrequired check before a release build can be started, configured forBuild Releaseenvironment.additionally, moved the create github release step so that it is triggered after the docker image is built/pushed .