Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required check for release build #5934

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Add required check for release build #5934

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37ab5e7
Add required check for release build
wileyj Mar 17, 2025
efb7480
Remove armv7 build and restore order of operations in release workflow
wileyj Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/github-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ jobs:
inputs.signer_tag != ''
name: Build Binaries
runs-on: ubuntu-latest
environment: "Build Release"
strategy:
## Run a maximum of 10 builds concurrently, using the matrix defined in inputs.arch
max-parallel: 10
Expand All @@ -62,7 +63,6 @@ jobs:
- windows
cpu:
- arm64
- armv7
- x86-64 ## defaults to x86-64-v3 variant - intel haswell (2013) and newer
# - x86-64-v2 ## intel nehalem (2008) and newer
# - x86-64-v3 ## intel haswell (2013) and newer
Expand Down Expand Up @@ -108,8 +108,10 @@ jobs:
is_signer_release: ${{ inputs.is_signer_release }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}


## Builds arch dependent Docker images from binaries
##
## Note: this step requires the binaries in the create-release step to be uploaded
## Runs when the following is true:
## - either node or signer tag is provided
docker-image:
Expand Down
Loading