Skip to content

apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirandreww-starkware wants to merge 1 commit into from
Closed

apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ impl BroadcastNetworkStressTestNode {
/// Determines if this node should broadcast messages based on the mode
pub fn should_broadcast(&self) -> bool {
match self.args.user.mode {
Mode::AllBroadcast => true,
Mode::AllBroadcast | Mode::RoundRobin => true,

@cursor cursor Bot Feb 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RoundRobin mode behaves identically to AllBroadcast mode

Medium Severity

Mode::RoundRobin is grouped with Mode::AllBroadcast in should_broadcast, making all nodes broadcast simultaneously. This means selecting --mode rr produces identical behavior to --mode all — no turn-taking occurs and round_duration_seconds is never consulted anywhere. Users of this mode will get misleading behavior with no indication that round-robin isn't actually happening.

Fix in Cursor Fix in Web

Mode::OneBroadcast => {
let broadcaster_id = Self::get_broadcaster_id(&self.args);
self.args.runner.id == broadcaster_id
Expand Down
7 changes: 7 additions & 0 deletions crates/apollo_network_benchmark/src/node_args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ pub enum Mode {
/// Only the node specified by --broadcaster broadcasts messages
#[value(name = "one")]
OneBroadcast,
/// Nodes take turns broadcasting in round-robin fashion
#[value(name = "rr")]
RoundRobin,
}

#[derive(Debug, Clone, ValueEnum, PartialEq, Eq, Serialize, Deserialize)]
Expand Down Expand Up @@ -83,6 +86,10 @@ pub struct UserArgs {
#[arg(long, env, required_if_eq("mode", "one"))]
pub broadcaster: Option<u64>,

/// Duration each node broadcasts before switching (in seconds) - for RoundRobin mode
#[arg(long, env, default_value = "3")]
pub round_duration_seconds: u64,

/// Size of StressTestMessage
#[arg(long, env, default_value = "1024")]
pub message_size_bytes: usize,
Expand Down
Loading