[sirandreww-starkware]

Note

Low Risk
Changes are limited to benchmark CLI/options and a small gating condition for whether a node sends messages; no production networking logic is modified.

Overview
Adds a new stress-test Mode::RoundRobin (CLI value rr) and a corresponding --round-duration-seconds argument (default 3) to configure how long each node should broadcast before switching.

Updates BroadcastNetworkStressTestNode::should_broadcast to treat RoundRobin as a broadcasting mode (same decision path as AllBroadcast), enabling message sender startup when mode=rr.

^{Written by Cursor Bugbot for commit 3cf9aa8. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_network_benchmark: implement RoundRobin broadcasting logic #11560 : 3 dependent PRs (#11561 , #12722 , #13288 )
• apollo_network_benchmark: add seconds_since_epoch helper function #11559
• apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558 👈 (View in Graphite)
• apollo_network_benchmark: add message index detection mechanism #11557
• apollo_network_benchmark: add MessageIndexTracker struct #11556
• apollo_network_benchmark: add ReversedSqmr receiver and registration #11555
• apollo_network_benchmark: add ReversedSqmrSender struct and implementation #11554
• apollo_network_benchmark: add ReversedSqmr variant to NetworkProtocol enum #11553
• apollo_network_benchmark: add Sqmr variant to MessageReceiver and registration #11552
• apollo_network_benchmark: add Sqmr variant to MessageSender with send logic #11551
• apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum #11550
• apollo_network_benchmark: add SQMR protocol constant #11549
• apollo_network_benchmark: added ping latency metrics #11548
• apollo_network_benchmark: added network event metrics #11547
• apollo_network_benchmark: added SQMR session metrics #11546
• apollo_network_benchmark: added broadcast topic metrics #11545
• apollo_network_benchmark: added network metrics to network manager #11544
• apollo_network_benchmark: added broadcast metrics tracking #11543
• apollo_network_benchmark: added conditional broadcasting based on mode #11542
• apollo_network_benchmark: added broadcasting mode selection #11541
• apollo_network_benchmark: added message broadcasting task #10734 : 1 other dependent PR (#8303 )
• apollo_network_benchmark: added register metrics #10660 : 1 other dependent PR (#10661 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[cursor]

RoundRobin mode behaves identically to AllBroadcast mode

Medium Severity

Mode::RoundRobin is grouped with Mode::AllBroadcast in should_broadcast, making all nodes broadcast simultaneously. This means selecting --mode rr produces identical behavior to --mode all — no turn-taking occurs and round_duration_seconds is never consulted anywhere. Users of this mode will get misleading behavior with no indication that round-robin isn't actually happening.