ci: create and sign separate bundle ID for PRs #19505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (15)
|
siddarthkay
force-pushed
the
fix-ios-signing
branch
from
091d40a to
a011dd8
Compare
Member
✔️ status-desktop/prs/android/arm64/package/PR-19505#5 🔹 ~12 min 🔹 bae4abc9 🔹 📦 android/arm64 package |
siddarthkay
force-pushed
the
fix-ios-signing
branch
3 times, most recently
from
47ae31a to
f0d0ce0
Compare
Member
Jenkins BuildsClick to see older builds (383)
|
siddarthkay
force-pushed
the
fix-ios-signing
branch
12 times, most recently
from
47b5bee to
42a65d4
Compare
- points to `fix-ios-signing-with-fastlane` branch of `status-jenkins-lib` which provides development certs for PR builds and distribution certs for release builds. - adds nix flake to provide ruby dependencies for `fastlane` - adds config for new build identifier for PRs: `app.status.mobile.pr`
siddarthkay
force-pushed
the
fix-ios-signing
branch
from
42a65d4 to
41514ea
Compare
siddarthkay
force-pushed
the
fix-ios-signing
branch
2 times, most recently
from
c951e84 to
9e816b7
Compare
siddarthkay
force-pushed
the
fix-ios-signing
branch
from
9e816b7 to
6b92160
Compare
yakimant
reviewed
Dec 17, 2025
Member
yakimant
left a comment
yakimant
left a comment
There was a problem hiding this comment.
Left some comments, please have a look. (also in jenkin lib repo)
Will be happy to do a second go.
| ARCH = "x86_64" | ||
| /* iOS app paths */ | ||
| /* iOS app paths - PR builds use StatusPR, release builds use Status */ | ||
| STATUS_IOS_APP_NAME = "${utils.isReleaseBuild() ? 'Status' : 'StatusPR'}" |
Member
There was a problem hiding this comment.
Is it needed? We rename to STATUS_IOS_APP_ARTIFACT anyway.
Do we need to build both PR and non-pr?
Contributor
Author
There was a problem hiding this comment.
Is it needed? We rename to STATUS_IOS_APP_ARTIFACT anyway.
this var is helpful to find the build artefact to be used for rename.
Do we need to build both PR and non-pr?
in public CI we only build PR build and in release CI we build the main one.
I believe the same jenkinsfile is used for both, hence this is needed here.
mobile/fastlane/Fastfile
Outdated
Comment on lines
149
to
151
| signing_identity = ENV["sigh_#{app_identifier}_#{profile_type}_certificate-name"] || | ||
| lane_context[SharedValues::MATCH_PROVISIONING_PROFILE_MAPPING]&.dig(app_identifier) || | ||
| get_signing_identity(profile_type) |
Member
There was a problem hiding this comment.
Why 3 options?
Isnt running match enough for straight single option?
mobile/fastlane/Fastfile
Outdated
| match(match_params) | ||
| end | ||
|
|
||
| private_lane :sign_app do |options| |
Member
There was a problem hiding this comment.
Wonder if you can replace the logic with
- pack to ipa
- https://docs.fastlane.tools/actions/resign/
Contributor
Author
There was a problem hiding this comment.
This looks interesting indeed.
Contributor
Author
There was a problem hiding this comment.
I've pushed change in CI, lets see if it works or not.
| xcodebuild -configuration Release -target "Qt Preprocess" -sdk "$SDK" -arch "$ARCH" CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO CURRENT_PROJECT_VERSION=$BUILD_VERSION | xcbeautify | ||
| # Compile the app | ||
| xcodebuild -configuration Release -target Status install -sdk "$SDK" -arch "$ARCH" DSTROOT="$BIN_DIR" INSTALL_PATH="/" TARGET_BUILD_DIR="$BIN_DIR" CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO CURRENT_PROJECT_VERSION=$BUILD_VERSION | xcbeautify | ||
| xcodebuild -configuration Release -target "$TARGET_NAME" install -sdk "$SDK" -arch "$ARCH" DSTROOT="$BIN_DIR" INSTALL_PATH="/" TARGET_BUILD_DIR="$BIN_DIR" CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO CURRENT_PROJECT_VERSION=$BUILD_VERSION | xcbeautify |
Member
There was a problem hiding this comment.
We could probable make life simpler with gym and Gymfile, but maybe later:
https://docs.fastlane.tools/actions/gym
Contributor
Author
There was a problem hiding this comment.
yeah true I would put the gym stuff as a nice to have and in another PR.
siddarthkay
force-pushed
the
fix-ios-signing
branch
from
7ba9ed6 to
a654fd6
Compare
siddarthkay
force-pushed
the
fix-ios-signing
branch
from
a654fd6 to
5742e5d
Compare
siddarthkay
force-pushed
the
fix-ios-signing
branch
from
11f3557 to
1674de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix-ios-signing-with-fastlanebranch ofstatus-jenkins-libwhich provides development certs for PR builds and distribution certs for release builds.fastlaneapp.status.mobile.pr