-
Notifications
You must be signed in to change notification settings - Fork 90
ci: create and sign separate bundle ID for PRs #19505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
siddarthkay
wants to merge
11
commits into
master
Choose a base branch
from
fix-ios-signing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+852
−438
Open
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
41514ea
ci: create and sign separate bundle ID for PRs
siddarthkay e986068
ci: upload iOS PR to Diawi
siddarthkay 6b92160
ci: iOS job for release
siddarthkay 711d934
ci: fix release job path
siddarthkay f15fd77
chore: address feedback
siddarthkay f0e3aaf
chore: use fastlane resign action
siddarthkay 5742e5d
debug: very verbose logs
siddarthkay 9d111ba
chore: xcode wrapper in nix flake
siddarthkay 1674de3
fix: resign expects provisioning profile
siddarthkay 33d96dc
chore: some cleanup
siddarthkay 0e0f8d5
chore: more feedback
siddarthkay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,3 +26,66 @@ It also expects the presence of the following credentials: | |
| * `macos-keychain-file` - Keychain file with the MacOS signing certificate. | ||
|
|
||
| You can read about how to create such a keychain [here](https://github.com/status-im/infra-docs/blob/master/articles/macos_signing_keychain.md). | ||
|
|
||
| ## iOS | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this could be somewhere in |
||
|
|
||
| iOS builds use **fastlane** with **match** for code signing management. This provides: | ||
| - Automatic certificate and profile management | ||
| - Separate signing for PR vs release builds | ||
|
|
||
| ### Bundle Identifiers | ||
|
|
||
| | Build Type | Bundle ID | Fastlane Lane | | ||
| |------------|-----------|---------------| | ||
| | PR builds | `app.status.mobile.pr` | `pr` | | ||
| | Release | `app.status.mobile` | `release` | | ||
siddarthkay marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ### Certificate Types | ||
|
|
||
| | Build Type | Certificate Type | Match Type | Purpose | | ||
| |------------|------------------|------------|---------| | ||
| | PR builds | Apple Development | `development` | Testing on registered devices | | ||
siddarthkay marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| | Release | Apple Distribution | `appstore` | App Store / TestFlight | | ||
|
|
||
| ### Fastlane Files | ||
|
|
||
| The `fastlane` configuration is located in `mobile/fastlane/`: | ||
|
|
||
| | File | Purpose | | ||
| |------|---------| | ||
| | `Fastfile` | Defines build lanes (pr, nightly, release) | | ||
| | `Matchfile` | Configures match for certificate management | | ||
| | `Appfile` | App identifiers and team configuration | | ||
| | `Gemfile` | Ruby dependencies | | ||
|
|
||
|
|
||
| ### Local Development | ||
|
|
||
| To run `fastlane` locally for testing: | ||
|
|
||
| ```bash | ||
| cd mobile/fastlane | ||
| nix --extra-experimental-features 'nix-command flakes' develop | ||
| bundle install | ||
|
|
||
| # Run a specific lane | ||
| bundle exec fastlane ios pr | ||
| bundle exec fastlane ios release | ||
| ``` | ||
|
|
||
| ### Revoking/Rotating Certificates | ||
|
|
||
| If a certificate is compromised or revoked: | ||
|
|
||
| ```bash | ||
| cd mobile/fastlane | ||
|
|
||
| # Nuke existing certificates (warning!! watch what you nuke) | ||
| bundle exec fastlane match nuke development | ||
| bundle exec fastlane match nuke distribution | ||
|
|
||
| # Regenerate | ||
| bundle exec fastlane match development --app_identifier "app.status.mobile.pr" | ||
| bundle exec fastlane match appstore --app_identifier "app.status.mobile" | ||
| ``` | ||
|
|
||
siddarthkay marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Default environment variables for fastlane | ||
| # These can be overridden by CI environment | ||
|
|
||
| # Disable fastlane colors in CI | ||
| FASTLANE_DISABLE_COLORS=1 | ||
|
|
||
| # Skip session verification | ||
| FASTLANE_SESSION="" | ||
|
|
||
| # Team ID | ||
| FASTLANE_TEAM_ID=8B5X2M6H2Y | ||
siddarthkay marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
siddarthkay marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Gems installed locally | ||
| .gems/ | ||
| vendor/bundle/ | ||
|
|
||
| # Bundler | ||
| .bundle/ | ||
|
|
||
| # Fastlane | ||
| fastlane/report.xml | ||
| fastlane/Preview.html | ||
| fastlane/screenshots/ | ||
| fastlane/test_output/ | ||
|
|
||
| # Nix | ||
| result |
siddarthkay marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 3.2.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # App identifiers for Status App iOS builds | ||
| app_identifier("app.status.mobile") | ||
| apple_id(ENV["FASTLANE_APPLE_ID"]) | ||
| team_id("8B5X2M6H2Y") | ||
siddarthkay marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| itc_team_id(ENV["FASTLANE_ITC_TEAM_ID"]) | ||
siddarthkay marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| for_lane :pr do | ||
| app_identifier("app.status.mobile.pr") | ||
| end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.