Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API definitions to conform to the new Soroban RPC schemas #173

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Update API definitions to conform to the new Soroban RPC schemas #173

merged 2 commits into from
Dec 1, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 30, 2023

This includes:

@Shaptic Shaptic self-assigned this Nov 30, 2023
@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Nov 30, 2023
@Shaptic Shaptic mentioned this pull request Nov 30, 2023
Merged
3 tasks
@Shaptic Shaptic force-pushed the stable branch 2 times, most recently from ae26bef to 03cff76 Compare November 30, 2023 22:13
sreuland
sreuland approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it's now deprecated in favor of js-stellar-sdk, not digging too deep here, hopefully changes winding down.

@Shaptic Shaptic merged commit 0633a8b into stable Dec 1, 2023
4 checks passed
@Shaptic Shaptic deleted the update-schemas branch December 1, 2023 21:21
Shaptic added a commit that referenced this pull request Dec 6, 2023
@Shaptic
Prepare release w/ support for stable Protocol 20 and RPC. (#167)
4caf267 
* Update library to latest stellar-base
* Drop expiration workaround in lieu of new TTL in schema (#168)
* Upgrade minimum Node version to 18, add fixups for Node 20
* Update API in accordance with new RPC schemas (#173)
* Mark as stable version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreuland sreuland sreuland approved these changes

@2opremio 2opremio Awaiting requested review from 2opremio

@stellarsaur stellarsaur Awaiting requested review from stellarsaur

Assignees

@Shaptic Shaptic

Labels
None yet
Projects
Platform Scrum
Status: Done
Milestone
Soroban Stable P20 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shaptic @sreuland