Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Convert Start Ledger to String for Events Command #1117

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Don't Convert Start Ledger to String for Events Command #1117

merged 2 commits into from
Dec 7, 2023

Conversation

stellarsaur
Copy link
Contributor

What

soroban events takes a uint32 for the start-ledger param. We should not convert it to a string before calling the RPC endpoint.

@sreuland
Copy link
Contributor

sreuland commented Dec 7, 2023

should the target be a v20.0.1 branch off the v20.0.0 tag to enable hotfix, then can port to main afterwards?

@stellarsaur stellarsaur changed the base branch from main to v20.0.1 December 7, 2023 23:14
@stellarsaur stellarsaur changed the base branch from v20.0.1 to main December 7, 2023 23:16
@stellarsaur stellarsaur changed the base branch from main to release/v20.0.1 December 7, 2023 23:18
@stellarsaur
Copy link
Contributor Author

should the target be a v20.0.1 branch off the v20.0.0 tag to enable hotfix, then can port to main afterwards?

Yeah that's a better idea; done

sreuland
sreuland approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be good to create a ticket for tracking later on local/unit test coverage that could assert some of the rpc schema expectations.

@stellarsaur stellarsaur merged commit 7fd9107 into release/v20.0.1 Dec 7, 2023
21 of 22 checks passed
@stellarsaur stellarsaur deleted the cli-events-fix branch December 7, 2023 23:28
@sreuland
Copy link
Contributor

sreuland commented Dec 8, 2023

@stellarsaur , is ok to proceed with merging release/v20.0.1 back to main?, then we can renable e2e on main and pass, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreuland sreuland sreuland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellarsaur @sreuland