Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Convert Start Ledger to String for Events Command #1117

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Don't Convert Start Ledger to String for Events Command #1117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5571538
Don't convert start ledger to string for events command
stellarsaur Dec 7, 2023
214a0df
converted event.ledger to integer type
sreuland Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/soroban-cli/src/rpc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ pub struct Event {
#[serde(rename = "type")]
pub event_type: String,

pub ledger: String,
pub ledger: u32,
#[serde(rename = "ledgerClosedAt")]
pub ledger_closed_at: String,

Expand Down Expand Up @@ -822,7 +822,7 @@ soroban config identity fund {address} --helper-url <url>"#

let mut oparams = ObjectParams::new();
match start {
EventStart::Ledger(l) => oparams.insert("startLedger", l.to_string())?,
EventStart::Ledger(l) => oparams.insert("startLedger", l)?,
EventStart::Cursor(c) => {
pagination.insert("cursor".to_string(), c.into());
}
Expand Down
Loading