fix(dolt): complete schema_version upgrades#2635
Closed
garitar wants to merge 1 commit intosteveyegge:mainfrom
Closed
fix(dolt): complete schema_version upgrades#2635garitar wants to merge 1 commit intosteveyegge:mainfrom
garitar wants to merge 1 commit intosteveyegge:mainfrom
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
DreadPirateRobertz
approved these changes
Mar 16, 2026
Contributor
DreadPirateRobertz
left a comment
DreadPirateRobertz
left a comment
There was a problem hiding this comment.
Clean fix for #2634 — bumps schema version to 8 and adds regression tests verifying that (1) one-version-behind databases get the latest migrations re-applied, and (2) config table isn't left dirty in dolt_status after schema init. LGTM.
steveyegge
added a commit
that referenced
this pull request
Mar 17, 2026
Existing databases at schema version 7 were skipping the no_history migration. Bumping to 8 forces re-initialization. Also commits the schema_version update so repos don't stay dirty in dolt_status. Co-Authored-By: garitar <garitar@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
currentSchemaVersionto8so repos one version behind actually re-run the latest migration-backed columnsconfig.schema_versionupdate so repos do not stay dirty indolt_statusafter init/upgradeFixes #2634.
Related overlap: #2632 covers embedded Dolt schema files only; this PR fixes the Dolt-backed repo upgrade path and schema-version bookkeeping.
Validation
go test ./internal/storage/dolt -run '^(TestSchemaVersionSetAfterInit|TestSchemaVersionRunsLatestMigrationsWhenOneVersionBehind|TestSchemaVersionRunsInitWhenStale)$' -count=1