Add options for passing client's credentials with env variables #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is super cool!...it'll also simplify a bit when web3-storage/w3up-client#74 is merged and released. |
Great that you like it! Do you plan to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow interaction with web3.storage service using credentials (principal key and delegation proof) passed as base64-encoded env variables.
Rationale
Taking AWS CLI as an example, you can either use
aws configureand store the credentials in your local config file or useawswith "inline" credentials.This PR will help the
w3in the ad-hoc usage and for the multi-tenant environments.