Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly checks so that error value exists before trying to show one in useAsyncStoryblok #316

Merged
merged 4 commits into from
Apr 19, 2023

Conversation

SebbeJohansson
Copy link
Contributor

@alvarosabu alvarosabu requested a review from Dawntraoz March 2, 2023 07:14
@alvarosabu
Copy link
Contributor

@SebbeJohansson pipelines broke, can you please check if the lock is updated?

@SebbeJohansson
Copy link
Contributor Author

@alvarosabu I think that issue is coming from my change in the playground where I am including the storyblok-nuxt package locally instead of using the public version (or what ever it was doing before).
I can fix the package file, but I would love it if you could give me some feedback on whether or not you think its a good idea to locally refer to the package.

@alvarosabu
Copy link
Contributor

Set the playground ref to "0.0.1" to avoid issues

@SebbeJohansson
Copy link
Contributor Author

SebbeJohansson commented Mar 2, 2023

@alvarosabu can you confirm that playground works at all for you if you do that? Cause it ain't for me! 😁😅
image

@SebbeJohansson
Copy link
Contributor Author

I reverted the change anyways, but the pipeline still failed.

@SebbeJohansson
Copy link
Contributor Author

Something went wrong when i commited this because the useASyncStoryblok composable looks weird as all hell.
image

Maybe something went wrong when I merged main. Not entirely sure.

I have updated it and it should now run fine. I am still having the issue above when I reverted the package.json file. Not sure what to do.

@Dawntraoz Dawntraoz merged commit b6c213a into storyblok:main Apr 19, 2023
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SebbeJohansson SebbeJohansson deleted the fix/empty-error-value branch April 19, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants