Speed up checkout action in dead code check #5878
Open
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cttsai-stripe
changed the title
| uses: actions/checkout@v2 | ||
| with: | ||
| fetch-depth: 0 | ||
| uses: actions/checkout@v6 |
Collaborator
There was a problem hiding this comment.
I think we do this on purpose so that we can compare with merge base. I think if you modified some swift code in this PR to get the check to run it might fail.
Author
There was a problem hiding this comment.
https://github.com/stripe/stripe-ios/actions/runs/19905920015/job/57061959041 is the check that passed on a commit with swift code change. I uncommitted that change when ready for review. But if fetch-depth is necessary, I can close this PR and keep the issue open for the next iOS runner to investigate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the action version and remove
fetch-depth: 0to speed up the action.Reducing the checkout time from averaging ~2m to under 20s.
https://github.com/stripe/stripe-ios/actions/runs/19905920015/job/57061959041
Starting from checkout-v4:
Motivation
In the worst scenario, it takes 9 minutes to checkout.
https://stripe.slack.com/archives/C02HQBW38JX/p1764783011920219