Skip to content

Speed up checkout action in dead code check #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cttsai-stripe wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −3
Open

Speed up checkout action in dead code check #5878

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf5ef67
update checkout action version
cttsai-stripe Dec 3, 2025
07875b6
try to trigger dead code check
cttsai-stripe Dec 3, 2025
af90868
remove unecessary changes
cttsai-stripe Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/find-dead-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v2
with:
fetch-depth: 0
uses: actions/checkout@v6
Copy link
Collaborator

@porter-stripe porter-stripe Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do this on purpose so that we can compare with merge base. I think if you modified some swift code in this PR to get the check to run it might fail.

Copy link
Author

@cttsai-stripe cttsai-stripe Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/stripe/stripe-ios/actions/runs/19905920015/job/57061959041 is the check that passed on a commit with swift code change. I uncommitted that change when ready for review. But if fetch-depth is necessary, I can close this PR and keep the issue open for the next iOS runner to investigate it.


- name: Setup Xcode
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
Expand Down