Skip to content

Conversation

@porter-stripe
Copy link
Collaborator

Summary

  • Adds some missing namespaces for embedded
  • All backward compatible

Motivation

  • Cleaner API

Testing

Compiler

Changelog

N/A

@porter-stripe porter-stripe marked this pull request as ready for review January 7, 2026 18:39
@porter-stripe porter-stripe requested review from a team as code owners January 7, 2026 18:39
@porter-stripe porter-stripe enabled auto-merge (squash) January 7, 2026 18:39
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

⚠️ Public API changes detected:

StripePaymentSheet

- public var cardBrandAcceptance: StripePaymentSheet.PaymentSheet.CardBrandAcceptance
+ public var cardBrandAcceptance: StripePaymentSheet.EmbeddedPaymentElement.CardBrandAcceptance
+ public typealias BrandCategory = StripePaymentSheet.PaymentSheet.CardBrandAcceptance.BrandCategory
+ public typealias CardBrandAcceptance = StripePaymentSheet.PaymentSheet.CardBrandAcceptance

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

public typealias CustomPaymentMethodConfiguration = PaymentSheet.CustomPaymentMethodConfiguration
@_spi(CardFundingFilteringPrivatePreview) public typealias CardFundingType = PaymentSheet.CardFundingType
public typealias CardBrandAcceptance = PaymentSheet.CardBrandAcceptance
public typealias BrandCategory = PaymentSheet.CardBrandAcceptance.BrandCategory
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is BrandCategory used anywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but not explicitly. It is used under the CardBrandAcceptance name-space. So, EmbeddedPaymentElement.Configuration.CardBrandAcceptance.BrandCategory. It's used in the card brand filtering API.

@porter-stripe porter-stripe merged commit 72a180f into master Jan 9, 2026
9 of 10 checks passed
@porter-stripe porter-stripe deleted the porter/embedded-namespaces branch January 9, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants