Skip to content

Add some embedded namespaces #5955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
porter-stripe merged 1 commit into from
Jan 9, 2026
Merged

Add some embedded namespaces #5955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...PaymentSheet/StripePaymentSheet/Source/PaymentSheet/Embedded/EmbeddedPaymentElement.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,9 @@ extension EmbeddedPaymentElement {
public typealias BillingDetailsCollectionConfiguration = PaymentSheet.BillingDetailsCollectionConfiguration
public typealias ExternalPaymentMethodConfiguration = PaymentSheet.ExternalPaymentMethodConfiguration
public typealias CustomPaymentMethodConfiguration = PaymentSheet.CustomPaymentMethodConfiguration
@_spi(CardFundingFilteringPrivatePreview) public typealias CardFundingType = PaymentSheet.CardFundingType
public typealias CardBrandAcceptance = PaymentSheet.CardBrandAcceptance
public typealias BrandCategory = PaymentSheet.CardBrandAcceptance.BrandCategory
Copy link
Collaborator

@joyceqin-stripe joyceqin-stripe Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is BrandCategory used anywhere?

Copy link
Collaborator Author

@porter-stripe porter-stripe Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but not explicitly. It is used under the CardBrandAcceptance name-space. So, EmbeddedPaymentElement.Configuration.CardBrandAcceptance.BrandCategory. It's used in the card brand filtering API.

}

// MARK: - EmbeddedPaymentElement.PaymentOptionDisplayData
Expand Down
4 changes: 2 additions & 2 deletions ...StripePaymentSheet/Source/PaymentSheet/Embedded/EmbeddedPaymentElementConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,14 +135,14 @@ extension EmbeddedPaymentElement {
/// Note: For Apple Pay, the list of supported card brands is determined by combining `StripeAPI.supportedPKPaymentNetworks()` with `StripeAPI.additionalEnabledApplePayNetworks` and then applying the `cardBrandAcceptance` filter. This filtered list is then assigned to `PKPaymentRequest.supportedNetworks`, ensuring that only the allowed card brands are available for Apple Pay transactions. Any `PKPaymentNetwork` that does not correspond to a `BrandCategory` will be blocked if you have specified an allow list, or will not be blocked if you have specified a disallow list.
/// Note: This is only a client-side solution.
/// Note: Card brand filtering is not currently supported by Link.
public var cardBrandAcceptance: PaymentSheet.CardBrandAcceptance = .all
public var cardBrandAcceptance: CardBrandAcceptance = .all

/// By default, the embedded payment element will accept cards of all funding types (credit, debit, prepaid, unknown).
/// You can specify which card funding types to allow.
/// When a customer enters a card that isn't allowed, a warning will be displayed, but they can still complete the payment.
///
/// This is a client-side UX feature only. You must validate the funding type on your server using the confirmation token or radar rules before confirming the payment to ensure only allowed funding types are accepted.
@_spi(CardFundingFilteringPrivatePreview) public var allowedCardFundingTypes: PaymentSheet.CardFundingType = .all
@_spi(CardFundingFilteringPrivatePreview) public var allowedCardFundingTypes: CardFundingType = .all

/// By default, the card form will provide a button to open the card scanner.
/// If true, the card form will instead initialize with the card scanner already open.
Expand Down
Loading