Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add create Channel endpoint #743

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

filipecabaco
Copy link
Member

What kind of change does this PR introduce?

Add create Channel endpoint

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2023 0:53am

@filipecabaco filipecabaco requested review from chasers, abc3 and a team November 17, 2023 21:37
Copy link
Contributor

@wojtekmach wojtekmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one comment about returning {:error, changeset} on errors.

lib/realtime/repo.ex Outdated Show resolved Hide resolved
test/realtime/repo_test.exs Outdated Show resolved Hide resolved
@filipecabaco filipecabaco force-pushed the fix/create-channel-controller branch from cb0856b to eda2533 Compare November 20, 2023 12:53
@filipecabaco filipecabaco merged commit edca213 into main Nov 20, 2023
3 checks passed
@filipecabaco filipecabaco deleted the fix/create-channel-controller branch November 20, 2023 12:58
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.25.37 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants