-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleaning #4359
base: nightly_dev
Are you sure you want to change the base?
Code cleaning #4359
Conversation
…t if there's none. supermerill/SuperSlicer/issues#778
I'm okay with removing warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too many changes that will makes merging harder. Please ask that in prusaslicer first.
ok, I understand the issue when merging from Prusa. I'll prepare a cleaner pull request for the elimination of warnings. |
I work on the OrcaSlicer project and I would LOVE to do this to Orca as well. Biggest issue is merging between the projects. Maybe we can get all of the Slic3r projects to agree on a clang-format standard and we could format all of the projects? In a perfect world :) |
5e0f604
to
787415d
Compare
These commits eliminate a lot of warnings while compiling (unused variables and functions, indenation, improper types). Inaddition there is one commit that does some cosmetics: remove trailing blanks and replaces tabs with 4 spaces.