Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleaning #4359

Open
wants to merge 13 commits into
base: nightly_dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 1 addition & 6 deletions .github/workflows/ccpp_mac.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
name: C/C++ Nightly macos

on:
push:
branches:
- Nigthly
- nightly_dev
- nightly_master
- debug_macos
workflow_dispatch:

jobs:
build:
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/ccpp_mac_arm.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
name: C/C++ Nightly arm macos

on:
push:
branches:
- Nigthly
- nightly_dev
- nightly_master
- debug_macos
workflow_dispatch:

jobs:
build:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/ccpp_mac_arm_debug.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: C/C++ debug arm macos

on:
push:
branches:
- debug_macos
workflow_dispatch:

jobs:
build:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/ccpp_mac_arm_rc.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: C/C++ Release candidate arm macos

on:
push:
branches:
- rc
workflow_dispatch:

jobs:
build:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/ccpp_mac_debug.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: C/C++ debug macos

on:
push:
branches:
- debug_macos
workflow_dispatch:

jobs:
build:
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/ccpp_mac_rc.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
name: C/C++ Release candidate macos

on:
push:
branches:
- rc
- debug_macos
workflow_dispatch:

jobs:
build:
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/ccpp_ubuntu.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
name: C/C++ Nightly ubuntu

on:
push:
branches:
- Nigthly
- nightly_dev
- nightly_master
- debug_ubuntu
workflow_dispatch:

jobs:
build:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/ccpp_ubuntu_debug.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: C/C++ debug ubuntu

on:
push:
branches:
- debug_ubuntu
workflow_dispatch:

jobs:
build:
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/ccpp_ubuntu_gtk3.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
name: C/C++ Nightly ubuntu-GTK3

on:
push:
branches:
- Nigthly
- nightly_dev
- nightly_master
- debug_ubuntu
workflow_dispatch:

jobs:
build:
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/ccpp_ubuntu_gtk3_debug.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: C/C++ debug ubuntu-GTK3

on:
push:
branches:
- debug_ubuntu
workflow_dispatch:

jobs:
build:
Expand Down Expand Up @@ -47,4 +45,4 @@ jobs:
with:
name: ${{ github.event.repository.name }}-gtk3.AppImage
path: build/${{ github.event.repository.name }}_ubu64.AppImage

4 changes: 1 addition & 3 deletions .github/workflows/ccpp_ubuntu_gtk3_rc.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: C/C++ Release candidate ubuntu-GTK3

on:
push:
branches:
- rc
workflow_dispatch:

jobs:
build:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/ccpp_ubuntu_rc.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: C/C++ Release candidate ubuntu

on:
push:
branches:
- rc
workflow_dispatch:

jobs:
build:
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/ccpp_win.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
name: C/C++ Nightly windows x64

on:
push:
branches:
- Nigthly
- nightly_dev
- nightly_master
workflow_dispatch:

jobs:

build:
runs-on: windows-2019

steps:
- uses: actions/checkout@v1
- uses: ilammy/msvc-dev-cmd@v1
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/ccpp_win_debug.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
name: C/C++ debug windows x64

on:
push:
branches:
- debug_win
workflow_dispatch:

jobs:

build_pot:
runs-on: windows-2019

steps:
- uses: actions/checkout@v1
- uses: ilammy/msvc-dev-cmd@v1
Expand Down Expand Up @@ -77,7 +75,7 @@ jobs:
build:
runs-on: windows-2019
needs: build_dep

steps:
- uses: actions/checkout@v1
- uses: ilammy/msvc-dev-cmd@v1
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/ccpp_win_deps.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: C/C++ dep build windows x64

on:
push:
branches:
- debug_win
workflow_dispatch:

jobs:
build_dep:
Expand All @@ -28,7 +26,7 @@ jobs:
build:
runs-on: windows-2019
needs: build_dep

steps:
- uses: actions/checkout@v1
- uses: ilammy/msvc-dev-cmd@v1
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/ccpp_win_rc.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
name: C/C++ Release candidate windows x64

on:
push:
branches:
- rc
workflow_dispatch:

jobs:

build:
runs-on: windows-2019

steps:
- uses: actions/checkout@v1
- uses: ilammy/msvc-dev-cmd@v1
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ local-lib
build*
deps/build*
deps/deps-*
cmake/CPackConfig.cmake

# MacOS Ignores
.DS_Store
Expand Down
2 changes: 1 addition & 1 deletion BuildLinux.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash

export ROOT=`pwd`
export NCORES=`nproc --all`
export NCORES=`nproc`
FOUND_GTK2=$(dpkg -l libgtk* | grep gtk2)
FOUND_GTK3=$(dpkg -l libgtk* | grep gtk-3)

Expand Down
Binary file added resources/localization/ca/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/cs/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/de/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/en/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/es/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/fr/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/hu/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/it/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/ja/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/ko/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/ko_KR/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/nl/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/pl/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/pt_BR/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/ru/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/tr/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/uk/SuperSlicer.mo
Binary file not shown.
Binary file added resources/localization/zh_CN/SuperSlicer.mo
Binary file not shown.
Binary file not shown.
1 change: 0 additions & 1 deletion src/ArcWelderLib
Submodule ArcWelderLib deleted from fe18f1
14 changes: 7 additions & 7 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ if (SLIC3R_GUI)
list(FILTER wxWidgets_LIBRARIES EXCLUDE REGEX expat)
list(APPEND wxWidgets_LIBRARIES libexpat)
endif ()

# This is an issue in the new wxWidgets cmake build, doesn't deal with librt
find_library(LIBRT rt)
if(LIBRT)
Expand Down Expand Up @@ -176,10 +176,10 @@ target_link_libraries(Slic3r libslic3r_gui)
endif ()
if (WIN32)
find_library(PSAPI_LIB NAMES Psapi)
if(NOT PSAPI_LIB)
if(NOT PSAPI_LIB)
message("WARNING: Psapi can't be find, trying again with hint to ${CMAKE_WINDOWS_KITS_10_DIR}/Lib/${CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION}/um/x64")
find_library(PSAPI_LIB Psapi PATH "${CMAKE_WINDOWS_KITS_10_DIR}/Lib/${CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION}/um/x64")
endif()
find_library(PSAPI_LIB Psapi PATH "${CMAKE_WINDOWS_KITS_10_DIR}/Lib/${CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION}/um/x64")
endif()
target_link_libraries(Slic3r ${PSAPI_LIB})
endif ()
endif ()
Expand All @@ -190,7 +190,7 @@ if (WIN32)
if (MINGW)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -municode")
endif()

configure_file(${CMAKE_CURRENT_SOURCE_DIR}/libslic3r/libslic3r_version.h.in ${CMAKE_CURRENT_BINARY_DIR}/libslic3r_version.h @ONLY)

add_executable(Slic3r_app_gui WIN32 PrusaSlicer_app_msvc.cpp ${CMAKE_CURRENT_BINARY_DIR}/${SLIC3R_APP_KEY}.rc)
Expand All @@ -216,7 +216,7 @@ if (WIN32)
target_link_libraries(Slic3r_app_console PRIVATE boost_headeronly)

add_executable(PrusaSlicer_app_gcodeviewer WIN32 PrusaSlicer_app_msvc.cpp ${CMAKE_CURRENT_BINARY_DIR}/${SLIC3R_APP_KEY}-gcodeviewer.rc ${CMAKE_CURRENT_BINARY_DIR}/libslic3r_version.h)
target_include_directories(PrusaSlicer_app_gcodeviewer PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} PUBLIC ${CMAKE_CURRENT_BINARY_DIR})
target_include_directories(PrusaSlicer_app_gcodeviewer PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} PUBLIC ${CMAKE_CURRENT_BINARY_DIR})
# Generate debug symbols even in release mode.
if (MSVC)
target_link_options(PrusaSlicer_app_gcodeviewer PUBLIC "$<$<CONFIG:RELEASE>:/DEBUG>")
Expand Down Expand Up @@ -287,7 +287,7 @@ else ()
endif ()
add_custom_command(TARGET Slic3r POST_BUILD
# COMMAND ln -sfn "${SLIC3R_RESOURCES_DIR}" "${BIN_RESOURCES_DIR}" # make[3]: stat: src/Slic3r: Too many levels of symbolic links
COMMAND cp -r "${SLIC3R_RESOURCES_DIR}" "${BIN_RESOURCES_DIR}"
COMMAND cp -r "${SLIC3R_RESOURCES_DIR}" "${BIN_RESOURCES_DIR}"
COMMENT "Symlinking the resources directory into the build tree"
VERBATIM)
endif ()
Expand Down
Loading