feat(swift-language-service): implement De Morgan's Law code action #2406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhantomInTheWire
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
PhantomInTheWire
force-pushed
the
feat/demorgan
branch
from
23aa7f9 to
8e68f62
Compare
ahoppen
reviewed
Jan 3, 2026
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Thanks a lot! The algorithm looks great! 🤩 I left some smaller comments inline.
Sources/SwiftLanguageService/CodeActions/ApplyDeMorganLaw.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ApplyDeMorganLaw.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ApplyDeMorganLaw.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ApplyDeMorganLaw.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ApplyDeMorganLaw.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ApplyDeMorganLaw.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ApplyDeMorganLaw.swift
Outdated
Show resolved
Hide resolved
PhantomInTheWire
force-pushed
the
feat/demorgan
branch
2 times, most recently
from
083d4b2 to
7f2ab55
Compare
PhantomInTheWire
force-pushed
the
feat/demorgan
branch
from
7f2ab55 to
caab951
Compare
Member
Author
|
@ahoppen should be good to review |
ahoppen
reviewed
Jan 5, 2026
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Very nice. I have a few more small comments inline.
Sources/SwiftLanguageService/CodeActions/ApplyDeMorganLaw.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftLanguageService/CodeActions/ApplyDeMorganLaw.swift
Outdated
Show resolved
Hide resolved
PhantomInTheWire
force-pushed
the
feat/demorgan
branch
from
caab951 to
4b996e8
Compare
Signed-off-by: Karan <[email protected]>
Signed-off-by: Karan <[email protected]>
PhantomInTheWire
force-pushed
the
feat/demorgan
branch
from
4ff0bb1 to
3eecf94
Compare
PhantomInTheWire
force-pushed
the
feat/demorgan
branch
from
3eecf94 to
874aeb0
Compare
ahoppen
reviewed
Jan 6, 2026
Sources/SwiftLanguageService/CodeActions/ApplyDeMorganLaw.swift
Outdated
Show resolved
Hide resolved
ahoppen
reviewed
Jan 6, 2026
Member
|
@swift-ci Please test |
Member
|
@swift-ci Please test Windows |
ahoppen
pushed a commit
that referenced
this pull request
Jan 13, 2026
fixes: #1569 mostly works but not sure what to do with many edge cases and has a todo for switch statements, also this will probably have conflicts with #2406 marking as draft till that merges and i can resolve the conflicts. https://github.com/user-attachments/assets/a6d07f9d-6f09-4330-8cd0-2d24bd6973fb --------- Signed-off-by: Karan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1243
previous/reference pr: #1552
Summary
Screen.Recording.2026-01-03.at.17.03.42.mov