Skip to content

feat(swift-language-service): implement De Morgan's Law code action #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahoppen merged 11 commits into from
Jan 7, 2026
+860 −1
Merged

feat(swift-language-service): implement De Morgan's Law code action #2406

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
60da243
feat(swift-language-service): implement De Morgan's Law code action
PhantomInTheWire Dec 28, 2025
4b996e8
test(sourcekit-lsp): add unit tests for De Morgan's Law code action
PhantomInTheWire Jan 3, 2026
7ffacf5
tests: remove comments, infavour of self documenting tests
PhantomInTheWire Jan 6, 2026
48097c1
Simplify DeMorgan test parsing
PhantomInTheWire Jan 6, 2026
8f08475
move assertDeMorganTransform to top-level
PhantomInTheWire Jan 6, 2026
80657b1
reduce access level of DeMorganTransformer to package
PhantomInTheWire Jan 6, 2026
9064216
refactor to avoid cast calls
PhantomInTheWire Jan 6, 2026
b2f8e1a
use multi-line string literal for line comment test
PhantomInTheWire Jan 6, 2026
874aeb0
collect all valid code actions
PhantomInTheWire Jan 6, 2026
28fb997
Minor test and header fix
PhantomInTheWire Jan 6, 2026
f7e2bc9
Order markers ascendingly and use 4 as invocation marker
PhantomInTheWire Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,7 @@ var targets: [Target] = [
"SwiftBasicFormat",
"SwiftDiagnostics",
"SwiftIDEUtils",
"SwiftOperators",
"SwiftParser",
"SwiftParserDiagnostics",
"SwiftRefactor",
Expand Down
2 changes: 2 additions & 0 deletions Sources/SwiftLanguageService/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ add_library(SwiftLanguageService STATIC
AdjustPositionToStartOfIdentifier.swift
ClosureCompletionFormat.swift
CodeActions/AddDocumentation.swift
CodeActions/ApplyDeMorganLaw.swift
CodeActions/ConvertIntegerLiteral.swift
CodeActions/ConvertJSONToCodableStruct.swift
CodeActions/ConvertStringConcatenationToStringInterpolation.swift
Expand Down Expand Up @@ -79,6 +80,7 @@ target_link_libraries(SwiftLanguageService PRIVATE
TSCBasic
SwiftSyntax::SwiftDiagnostics
SwiftSyntax::SwiftIDEUtils
SwiftSyntax::SwiftOperators
SwiftSyntax::SwiftParser
SwiftSyntax::SwiftParserDiagnostics
SwiftSyntax::SwiftRefactor
Expand Down
Loading