Do not log fault if BuildServermanager.mainFilesProvider is nil
#2415
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s perfectly fine for `mainFilesProvider` to be `nil` if we don’t have an index. We shouldn’t log a fault for that.
Member
Author
|
@swift-ci Please test |
rintaro
approved these changes
Jan 15, 2026
rintaro
reviewed
Jan 15, 2026
|
|
||
| package func mainFilesProvider<T: MainFilesProvider>(as: T.Type) async -> T? { | ||
| guard let mainFilesProvider = mainFilesProvider else { | ||
| guard let mainFilesProvider = await mainFilesProvider.value else { |
Member
There was a problem hiding this comment.
This will trap if mainFilesProvider was nil as it's IUO, but I assume it's fine because it's always initialized in init.
Member
Author
There was a problem hiding this comment.
Yes exactly. All the IUO members in SourceKit-LSP should be guaranteed to be initialized in init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s perfectly fine for
mainFilesProviderto benilif we don’t have an index. We shouldn’t log a fault for that.