Skip to content

Do not log fault if BuildServermanager.mainFilesProvider is nil #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahoppen merged 1 commit into from
Jan 16, 2026
+3 −3
Merged

Do not log fault if BuildServermanager.mainFilesProvider is nil #2415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/BuildServerIntegration/BuildServerManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,11 +380,11 @@ package actor BuildServerManager: QueueBasedMessageHandler {
}

package func mainFilesProvider<T: MainFilesProvider>(as: T.Type) async -> T? {
guard let mainFilesProvider = mainFilesProvider else {
guard let mainFilesProvider = await mainFilesProvider.value else {
Copy link
Member

@rintaro rintaro Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will trap if mainFilesProvider was nil as it's IUO, but I assume it's fine because it's always initialized in init.

Copy link
Member Author

@ahoppen ahoppen Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly. All the IUO members in SourceKit-LSP should be guaranteed to be initialized in init.

return nil
}
guard let index = await mainFilesProvider.value as? T else {
logger.fault("Expected the main files provider of the build server manager to be an `\(T.self)`")
guard let index = mainFilesProvider as? T else {
logger.fault("Expected the main files provider of the build server manager to be a '\(T.self)'")
return nil
}
return index
Expand Down