Open
Conversation
Co-authored-by: widgetbeck <163376292+widgetbeck@users.noreply.github.com>
Contributor
Author
|
legit test fail but i cant fully parse the error message. will look into it |
mqole
added
the
Licensed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Added shader support for character customizable markings.
Ideologically a port of github.com/impstation/imp-station-14/pull/842 by widgetbeck, but because of nubody all the code had to be rewritten. So its all original. Beck is fine w the relicense even if it wasnt
Opportunity to rewrite this also meant I got to make it possible to apply multiple shaders to a single marking, which aint in the imp implementation. See media for an example yaml.
ALSO- set debug random characters to false because i got pissed off testing this not being able to do markings but i can change that back if people want
Why / Balance
Prerequisite for a LOT of bullshit
Technical details
MarkingPrototypenow has an additional 'shaders' datafield, which takes a dictionary of two strings: state, and shader name.If this field is undefined, markings will use the default shader.
Shaders are modified in
ApplyMarkings. Unfortunately shader layer methods arent in the system, so we had to grabSpriteComponent. This isnt ideal but I'm not fucking with robust toolbox. In a beautiful world shaders would be attached to sprites directly anywayMedia
Requirements
Breaking changes
Markings now support shaders on individual sprite layers. Please see the associated PR for an example on how to implement this.