feat(protocol): basefee goes up faster [do not merge] #16551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
changed the title
feat(protocol): basefee goes up faster [do not merge]
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I change the base fee math based on OZ's feedback (multiplying
gasTarget * adjustmentQuotient).You can see from the modified test that it also works, and the basefee goes up faster -- it will reach 1gwei if gasExcess is
167*gasTarget, instead of the previous327*gasTarget.From this PR I think we can confirm both approach works (with or without multiplying
gasTarget * adjustmentQuotient), it's a matter of time to accumulate a bigger gasExcess.I encourage @Brechtpd and @adaki2004 to review this PR but do not suggest to merge it.