Skip to content

CI on every desktop target again, and SMLib clean under the USD build's warnings - #120

Merged
jyviko merged 3 commits into
replay/1.0.1from
ci-all-archs-clean
Nov 2, 2026
Merged

jyviko merged 3 commits into
replay/1.0.1from
ci-all-archs-clean

Conversation

@jyviko

@jyviko jyviko commented Nov 2, 2026

Copy link
Copy Markdown

SolidCraft pins this library on every target it ships, so it has to build and pass everywhere, cleanly.

  • CI on every target again. The C API workflow builds and tests Linux x86_64 and aarch64, macOS universal, and Windows x64 and ARM64. This reverts the Linux-only speed cut (CI: the C API workflow runs on Linux x86_64 only, for speed #99).
  • Warnings fixed at their causes. 19 warnings that the premake/USD build turns into errors (-Wall -Wshadow=local -Wunused-parameter -Werror) are fixed in our landed code. Two are real defects: a new[] freed with delete (SmCrvInVolume) and a refusal text passed as a format string (SmFilletExecutive). The rest are shadowed names, member order, a nonnull compare, two dead functions, a switch case and an unused variable, none of which changes behaviour.
  • Kept clean. A new CMake option, SMLIB_STRICT_WARNINGS (GCC), compiles SMLib with those flags as errors, and the Linux x86_64 job uses it.

Gate (aarch64 box): every SMLib source compiles with 0 warnings under those flags; ctest 22/22. This PR's CI is the check on the other targets.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ

jyviko and others added 3 commits November 2, 2026 02:33
SolidCraft pins this library on every target it ships, so the pull-request gate runs on all of
them: Linux x86_64 and aarch64, macOS universal, Windows x64 and ARM64. This reverts the
Linux-only speed cut (2136965).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
…dow=local -Wunused-parameter, -Werror): 19 warnings fixed at their causes

Gated: every SMLib source compiles with 0 warnings under those flags; the capi build and ctest (22/22) pass.

Real defects:
- SmCrvInVolume: the continuity name from SmGetContinuityTypeString (new TCHAR[32]) was freed with
  delete, not delete [] (-Wmismatched-new-delete; undefined behaviour).
- SmFilletExecutive: a refusal's text was passed to smos_sprintf as its format with no arguments
  (-Wformat-security); now through "%s". Two messages bound the inserted refusal text to 200
  characters (-Wformat-truncation): the text is under 64 characters, so no message changes.
Others, no behaviour change:
- -Wreorder: SmBlendCorner's constructor initializes its members in their declared order.
- -Wnonnull-compare: SmBallPatch and SmProceduralBlend operator== cast the address of a reference
  with SM_CAST_NONNULL_PTR (never null), not SM_CAST_PTR.
- -Wshadow=local: inner names renamed so that no later line changes which variable it means
  (SmBlendCorner sW -> sUV, SmBlendCornerBall sOn -> sVertex, SmBlendSetback sO -> sOp,
  SmFilletSection sR -> sRow, SmPrimitiveCreation rW -> rWt, SmFilletExecutive i -> iOver / iSolver).
- -Wunused-function: kf_InMaterial and the four-argument sm_HermitePoints, both dead, removed.
- -Wswitch: SM_FV_JOIN_SECTION listed with the vertex kinds that change nothing (as before).
- -Wunused-variable: SmFilletNx1ClosedCorner's iDebugLevel referenced (SM_REF1), as elsewhere.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLIB_STRICT_WARNINGS (GCC) compiles SMLib with -Wall -Wshadow=local -Wunused-parameter -Werror,
the warnings the premake/USD build turns into errors; the Linux x86_64 job of the C API workflow
builds with it, so a change that would break that build fails its pull request.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant