Repository navigation
CI on every desktop target again, and SMLib clean under the USD build's warnings - #120
Merged
Merged
Conversation
SolidCraft pins this library on every target it ships, so the pull-request gate runs on all of them: Linux x86_64 and aarch64, macOS universal, Windows x64 and ARM64. This reverts the Linux-only speed cut (2136965). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
…dow=local -Wunused-parameter, -Werror): 19 warnings fixed at their causes Gated: every SMLib source compiles with 0 warnings under those flags; the capi build and ctest (22/22) pass. Real defects: - SmCrvInVolume: the continuity name from SmGetContinuityTypeString (new TCHAR[32]) was freed with delete, not delete [] (-Wmismatched-new-delete; undefined behaviour). - SmFilletExecutive: a refusal's text was passed to smos_sprintf as its format with no arguments (-Wformat-security); now through "%s". Two messages bound the inserted refusal text to 200 characters (-Wformat-truncation): the text is under 64 characters, so no message changes. Others, no behaviour change: - -Wreorder: SmBlendCorner's constructor initializes its members in their declared order. - -Wnonnull-compare: SmBallPatch and SmProceduralBlend operator== cast the address of a reference with SM_CAST_NONNULL_PTR (never null), not SM_CAST_PTR. - -Wshadow=local: inner names renamed so that no later line changes which variable it means (SmBlendCorner sW -> sUV, SmBlendCornerBall sOn -> sVertex, SmBlendSetback sO -> sOp, SmFilletSection sR -> sRow, SmPrimitiveCreation rW -> rWt, SmFilletExecutive i -> iOver / iSolver). - -Wunused-function: kf_InMaterial and the four-argument sm_HermitePoints, both dead, removed. - -Wswitch: SM_FV_JOIN_SECTION listed with the vertex kinds that change nothing (as before). - -Wunused-variable: SmFilletNx1ClosedCorner's iDebugLevel referenced (SM_REF1), as elsewhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLIB_STRICT_WARNINGS (GCC) compiles SMLib with -Wall -Wshadow=local -Wunused-parameter -Werror, the warnings the premake/USD build turns into errors; the Linux x86_64 job of the C API workflow builds with it, so a change that would break that build fails its pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SolidCraft pins this library on every target it ships, so it has to build and pass everywhere, cleanly.
-Wall -Wshadow=local -Wunused-parameter -Werror) are fixed in our landed code. Two are real defects: anew[]freed withdelete(SmCrvInVolume) and a refusal text passed as a format string (SmFilletExecutive). The rest are shadowed names, member order, a nonnull compare, two dead functions, a switch case and an unused variable, none of which changes behaviour.SMLIB_STRICT_WARNINGS(GCC), compiles SMLib with those flags as errors, and the Linux x86_64 job uses it.Gate (aarch64 box): every SMLib source compiles with 0 warnings under those flags; ctest 22/22. This PR's CI is the check on the other targets.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ