Skip to content

Develop - #213

Merged
jyx-07 merged 4 commits into
masterfrom
develop
Jun 28, 2026
Merged

Develop#213
jyx-07 merged 4 commits into
masterfrom
develop

Conversation

@sooooooobinn

Copy link
Copy Markdown
Contributor

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the use of findAllWithHomebaseByDate with a new findAllByReservationDate method in GetHomebaseReservationService, leveraging Spring Data's @EntityGraph in HomebaseReservationRepository. Feedback suggests removing the now-redundant findAllWithHomebaseByDate method from the repository to maintain a clean interface.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +49 to +50
@EntityGraph(attributePaths = ["homebase"])
fun findAllByReservationDate(reservationDate: LocalDate): List<HomebaseReservationJpaEntity>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The newly added findAllByReservationDate method using @EntityGraph is functionally identical to the existing findAllWithHomebaseByDate method (which uses JPQL with JOIN FETCH). To prevent code redundancy and maintain a clean repository interface, please remove the unused findAllWithHomebaseByDate method from this interface.

@jyx-07
jyx-07 merged commit 054e32c into master Jun 28, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants