Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the use of findAllWithHomebaseByDate with a new findAllByReservationDate method in GetHomebaseReservationService, leveraging Spring Data's @EntityGraph in HomebaseReservationRepository. Feedback suggests removing the now-redundant findAllWithHomebaseByDate method from the repository to maintain a clean interface.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @EntityGraph(attributePaths = ["homebase"]) | ||
| fun findAllByReservationDate(reservationDate: LocalDate): List<HomebaseReservationJpaEntity> |
There was a problem hiding this comment.
The newly added findAllByReservationDate method using @EntityGraph is functionally identical to the existing findAllWithHomebaseByDate method (which uses JPQL with JOIN FETCH). To prevent code redundancy and maintain a clean repository interface, please remove the unused findAllWithHomebaseByDate method from this interface.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)