Skip to content

Develop #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyx-07 merged 4 commits into from
Jun 28, 2026
Merged

Develop #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
385dbb6
fix: 홈베이스 예약 조회 date 필터 적용 오류 수정
sooooooobinn Jun 22, 2026
9f8ced2
fix: data 파라미터로 해당 날짜 예약만 조회되도록 수정
sooooooobinn Jun 22, 2026
681fee4
fix: ci 오류 수정
sooooooobinn Jun 22, 2026
8685ab1
Merge pull request #212 from team-incube/feat/homebase
sooooooobinn Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...n/kotlin/team/incube/flooding/domain/homebase/repository/HomebaseReservationRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package team.incube.flooding.domain.homebase.repository

import org.springframework.data.jpa.repository.EntityGraph
import org.springframework.data.jpa.repository.JpaRepository
import org.springframework.data.jpa.repository.Query
import org.springframework.data.repository.query.Param
Expand Down Expand Up @@ -44,4 +45,7 @@ interface HomebaseReservationRepository : JpaRepository<HomebaseReservationJpaEn
@Param("reservationDate")
reservationDate: LocalDate,
): List<HomebaseReservationJpaEntity>

@EntityGraph(attributePaths = ["homebase"])
fun findAllByReservationDate(reservationDate: LocalDate): List<HomebaseReservationJpaEntity>
Comment on lines +49 to +50

@gemini-code-assist gemini-code-assist Bot Jun 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The newly added findAllByReservationDate method using @EntityGraph is functionally identical to the existing findAllWithHomebaseByDate method (which uses JPQL with JOIN FETCH). To prevent code redundancy and maintain a clean repository interface, please remove the unused findAllWithHomebaseByDate method from this interface.

}
2 changes: 1 addition & 1 deletion ...main/kotlin/team/incube/flooding/domain/homebase/service/GetHomebaseReservationService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class GetHomebaseReservationService(

@Transactional(readOnly = true)
fun getReservationList(reservationDate: LocalDate): List<GetHomebaseResponse> {
val reservations = reservationRepository.findAllWithHomebaseByDate(reservationDate)
val reservations = reservationRepository.findAllByReservationDate(reservationDate)
if (reservations.isEmpty()) return emptyList()
val membersByReservationId =
memberRepository
Expand Down
Loading