Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP: Add link to the PSC process #3294

Merged
merged 5 commits into from
Jan 22, 2025
Merged

GCP: Add link to the PSC process #3294

merged 5 commits into from
Jan 22, 2025

Conversation

xaf
Copy link
Contributor

@xaf xaf commented Jan 15, 2025

What does this PR do?

Enable the Google Cloud Private Service Connect link so it appears in the documentation.

Notes to reviewers

@fairlydurable fairlydurable added the work-in-progress This PR is not yet ready for technical or team review. Ideally it should be converted to a draft. label Jan 15, 2025

If you are interested in leveraging Google Cloud Private Service Connect in your Namespaces, [create a support ticket](/cloud/support#support-ticket) that includes the following information:

- Google Cloud Region: The Region in which your connection will go through.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't require the region, because the consumer must create the endpoint within the same region as the producer (e.g. temporal cloud namespace region). To enable cross-region connectivity within their VPC, they can enable Global Access on their consumer endpoint if they have the GLOBAL routing mode configured on their VPC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, and AWS now has a global option too which we should add to the documentation on the AWS side. That being said, as mentioned in the GCP call, I think for now it's better to keep asking the same information no matter for which cloud as it standardizes things across. Once we get to self-service with PCv3 we won't need any of those informations anymore and can clean things up!!

@xaf xaf marked this pull request as ready for review January 15, 2025 19:25
@xaf xaf requested a review from a team as a code owner January 15, 2025 19:25
Copy link
Contributor

@MasonEgger MasonEgger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, the rest looks good.

@MasonEgger MasonEgger merged commit 2893072 into main Jan 22, 2025
4 checks passed
@MasonEgger MasonEgger deleted the xaf/add_link_to_gcp_psc branch January 22, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress This PR is not yet ready for technical or team review. Ideally it should be converted to a draft.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants