-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCP: Add link to the PSC process #3294
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
815113d
GCP: Add link to the PSC process
xaf ea1e33e
update GCP PSC documentation
xaf f2ac884
Merge branch 'main' into xaf/add_link_to_gcp_psc
xaf c69424b
Merge branch 'main' into xaf/add_link_to_gcp_psc
xaf e850be8
Merge branch 'main' into xaf/add_link_to_gcp_psc
MasonEgger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't require the region, because the consumer must create the endpoint within the same region as the producer (e.g. temporal cloud namespace region). To enable cross-region connectivity within their VPC, they can enable Global Access on their consumer endpoint if they have the
GLOBAL
routing mode configured on their VPC.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, and AWS now has a global option too which we should add to the documentation on the AWS side. That being said, as mentioned in the GCP call, I think for now it's better to keep asking the same information no matter for which cloud as it standardizes things across. Once we get to self-service with PCv3 we won't need any of those informations anymore and can clean things up!!