fix: 3-networks-hub-and-spoke Deploying with Cloud Build step 9 fails (#1045) #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Thanks for the contribution @moszutij!
For clarity/safety, let's bump https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-hub-and-spoke/modules/base_shared_vpc/main.tf#L30 to "~> 7.2"
The lint CI should just need a terraform fmt on the listed files.
|
/gcbrun |
|
@apeabody thanks for your inputs! |
|
/gcbrun |
|
/gcbrun |
|
Guessing we might need to update the test resources for the new module version: |
|
Aligned subnet type definition with https://registry.terraform.io/modules/terraform-google-modules/network/google/7.2.0/submodules/subnets#inputs. The subnet_flow_logs value should now be correctly supplied to the subnet sub module to activate the network flow logs while adhering to the security foundation's organisational policies. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #1045