Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3-networks-hub-and-spoke Deploying with Cloud Build step 9 fails (#1045) #1046

Closed
2 changes: 1 addition & 1 deletion 3-networks-dual-svpc/modules/base_shared_vpc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
| private\_service\_connect\_ip | Internal IP to be used as the private service connect endpoint | `string` | n/a | yes |
| project\_id | Project ID for Private Shared VPC. | `string` | n/a | yes |
| secondary\_ranges | Secondary ranges that will be used in some of the subnets | `map(list(object({ range_name = string, ip_cidr_range = string })))` | `{}` | no |
| subnets | The list of subnets being created | `list(map(string))` | `[]` | no |
| subnets | The list of subnets being created | `list(object({subnet_name = string, subnet_ip = string, subnet_region = string }))` | `[]` | no |
| windows\_activation\_enabled | Enable Windows license activation for Windows workloads. | `bool` | `false` | no |

## Outputs
Expand Down
2 changes: 1 addition & 1 deletion 3-networks-dual-svpc/modules/base_shared_vpc/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ variable "bgp_asn_subnet" {
}

variable "subnets" {
type = list(map(string))
type = list(object({subnet_name = string, subnet_ip = string, subnet_region = string }))
description = "The list of subnets being created"
default = []
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
| project\_number | Project number for Restricted Shared VPC. It is the project INSIDE the regular service perimeter. | `number` | n/a | yes |
| restricted\_services | List of services to restrict. | `list(string)` | n/a | yes |
| secondary\_ranges | Secondary ranges that will be used in some of the subnets | `map(list(object({ range_name = string, ip_cidr_range = string })))` | `{}` | no |
| subnets | The list of subnets being created | `list(map(string))` | `[]` | no |
| subnets | The list of subnets being created | `list(object({subnet_name = string, subnet_ip = string, subnet_region = string }))` | `[]` | no |
| windows\_activation\_enabled | Enable Windows license activation for Windows workloads. | `bool` | `false` | no |

## Outputs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ variable "default_region2" {
}

variable "subnets" {
type = list(map(string))
type = list(object({subnet_name = string, subnet_ip = string, subnet_region = string }))
description = "The list of subnets being created"
default = []
}
Expand Down
2 changes: 1 addition & 1 deletion 3-networks-hub-and-spoke/modules/base_shared_vpc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
| private\_service\_connect\_ip | Internal IP to be used as the private service connect endpoint. | `string` | n/a | yes |
| project\_id | Project ID for Private Shared VPC. | `string` | n/a | yes |
| secondary\_ranges | Secondary ranges that will be used in some of the subnets | `map(list(object({ range_name = string, ip_cidr_range = string })))` | `{}` | no |
| subnets | The list of subnets being created | `list(map(string))` | `[]` | no |
| subnets | The list of subnets being created | `list(object({subnet_name = string, subnet_ip = string, subnet_region = string }))` | `[]` | no |
| windows\_activation\_enabled | Enable Windows license activation for Windows workloads. | `bool` | `false` | no |

## Outputs
Expand Down
2 changes: 1 addition & 1 deletion 3-networks-hub-and-spoke/modules/base_shared_vpc/variables.tf
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ variable "bgp_asn_subnet" {
}

variable "subnets" {
type = list(map(string))
type = list(object({subnet_name = string, subnet_ip = string, subnet_region = string }))
description = "The list of subnets being created"
default = []
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
| restricted\_net\_hub\_project\_number | The restricted net hub project number | `string` | `""` | no |
| restricted\_services | List of services to restrict. | `list(string)` | n/a | yes |
| secondary\_ranges | Secondary ranges that will be used in some of the subnets | `map(list(object({ range_name = string, ip_cidr_range = string })))` | `{}` | no |
| subnets | The list of subnets being created | `list(map(string))` | `[]` | no |
| subnets | The list of subnets being created | `list(object({subnet_name = string, subnet_ip = string, subnet_region = string }))` | `[]` | no |
| windows\_activation\_enabled | Enable Windows license activation for Windows workloads. | `bool` | `false` | no |

## Outputs
Expand Down
2 changes: 1 addition & 1 deletion 3-networks-hub-and-spoke/modules/restricted_shared_vpc/variables.tf
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ variable "default_region2" {
}

variable "subnets" {
type = list(map(string))
type = list(object({subnet_name = string, subnet_ip = string, subnet_region = string }))
description = "The list of subnets being created"
default = []
}
Expand Down