fix: bump version of terraform provider on cai-monitoring module #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-cit
requested review from
rjerrems,
gtsorbo,
eeaton,
sleighton2022 and
a team
as code owners
apeabody
approved these changes
Aug 22, 2024
bdashrad
reviewed
Sep 12, 2024
| @@ -162,9 +162,8 @@ module "cloud_function" { | |||
| service_config = { | |||
| service_account_email = google_service_account.cloudfunction.email | |||
| runtime_env_variables = { | |||
| ROLES = join(",", var.roles_to_monitor) | |||
| SOURCE_ID = google_scc_source.cai_monitoring.id | |||
| LOG_EXECUTION_ID = "true" | |||
There was a problem hiding this comment.
I saw the discussion about removing LOG_EXECUTION_ID to potentially resolve #1306, but it appears the provider upgrade solved the issue. Was removing this still intentional or an oversight?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the version of the terraform provider on cai-monitoring module to
">= 5.42"to fix #1306Terraform provider
5.42.0release notes