Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump version of terraform provider on cai-monitoring module #1328

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: bump version of terraform provider on cai-monitoring module #1328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions 1-org/modules/cai-monitoring/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,8 @@ module "cloud_function" {
service_config = {
service_account_email = google_service_account.cloudfunction.email
runtime_env_variables = {
ROLES = join(",", var.roles_to_monitor)
SOURCE_ID = google_scc_source.cai_monitoring.id
LOG_EXECUTION_ID = "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the discussion about removing LOG_EXECUTION_ID to potentially resolve #1306, but it appears the provider upgrade solved the issue. Was removing this still intentional or an oversight?

ROLES = join(",", var.roles_to_monitor)
SOURCE_ID = google_scc_source.cai_monitoring.id
}
}

Expand Down
4 changes: 2 additions & 2 deletions 1-org/modules/cai-monitoring/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 3.77, <=5.37"
version = ">= 5.42"
}
google-beta = {
source = "hashicorp/google-beta"
version = ">= 3.77, <=5.37"
version = ">= 5.42"
}
random = {
source = "hashicorp/random"
Expand Down