Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Network Refactoring #991

Merged
merged 42 commits into from
Dec 8, 2023
Merged

feat!: Network Refactoring #991

merged 42 commits into from
Dec 8, 2023

Conversation

Samir-Cit
Copy link
Contributor

Hello folks.

This PR is to refactor the network resources into the new folder layout.

Samir-Cit and others added 23 commits August 9, 2023 12:48
@Samir-Cit
Creating network folder
f55b01f
@Samir-Cit
Moving projects creation to network folder
acdcb05
@Samir-Cit
Minor fixes
edc235c
@daniel-cit
feat: include network folder in the hierarchical firewall policy
2f5d00d
@daniel-cit
feat: add tags to the network folder and update 1-org tests
24d643b
@daniel-cit
update readme files for network change
da35fe7
@Samir-Cit
Network module (private)
0cb6406
@Samir-Cit
CR fix.
6778f1b
@Samir-Cit
CR fix.
6af329a
@Samir-Cit
Using new network module.
22fb746
@Samir-Cit
Output network projects map
15b3e4c
@Samir-Cit
Fix build.
2ec7d32
@daniel-cit
organize code, fix shared_vpc projects outputs, update usage in step …
ec25a0b 
…3-networks
@daniel-cit
Merge remote-tracking branch 'origin/network-refactor' into network-r…
0e2744f 
…efactor
@daniel-cit
add tests for shared vpc projects in org test
308559c
@Samir-Cit
Change output map
65d3d17
@Samir-Cit
Change output base_shared_vpc_project_number
23cef19
@daniel-cit
remove creation of shared projects from step 2-environment
5487e6a
@daniel-cit
remove project_budget variables for shared vpc projects
4b65478
@daniel-cit
fix terraform fmt lint issue
e0dd727
@daniel-cit
fix README variable list
0ea3052
@Samir-Cit
Fix lint.
9467318
@Samir-Cit
Merge branch 'network-refactor' of github.com:Samir-Cit/terraform-exa…
b9864eb 
…mple-foundation into network-refactor
@Samir-Cit Samir-Cit marked this pull request as ready for review August 21, 2023 13:45
@Samir-Cit Samir-Cit requested review from rjerrems and a team as code owners August 21, 2023 13:45
@daniel-cit daniel-cit requested a review from gtsorbo as a code owner August 29, 2023 00:39
@daniel-cit daniel-cit mentioned this pull request Aug 29, 2023
Merged
@prateek2408 prateek2408 self-requested a review October 10, 2023 05:04
amandakarina
amandakarina reviewed Oct 11, 2023
View reviewed changes
1-org/modules/network/variables.tf Outdated Show resolved Hide resolved
1-org/modules/network/variables.tf Outdated Show resolved Hide resolved
1-org/envs/shared/outputs.tf Outdated Show resolved Hide resolved
1-org/envs/shared/outputs.tf Outdated Show resolved Hide resolved
1-org/envs/shared/outputs.tf Outdated Show resolved Hide resolved
1-org/envs/shared/outputs.tf Outdated Show resolved Hide resolved
1-org/modules/network/versions.tf Outdated Show resolved Hide resolved
@Samir-Cit @amandakarina
Apply suggestions from code review
9e6fc69 
Co-authored-by: Amanda Karina Lopes de Oliveira <[email protected]>
@Samir-Cit Samir-Cit changed the title feat: Network Refactoring feat!: Network Refactoring Nov 1, 2023
gtsorbo
gtsorbo approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes, but LGTM

1-org/modules/network/versions.tf Outdated Show resolved Hide resolved
@gtsorbo
Copy link
Contributor

gtsorbo commented Dec 7, 2023

/gcbrun

2 similar comments
@daniel-cit
Copy link
Contributor

/gcbrun

@daniel-cit
Copy link
Contributor

/gcbrun

@gtsorbo gtsorbo merged commit 5f698ed into terraform-google-modules:master Dec 8, 2023
5 checks passed
@release-please release-please bot mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandakarina amandakarina amandakarina left review comments

@gtsorbo gtsorbo gtsorbo approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

@prateek2408 prateek2408 Awaiting requested review from prateek2408

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Samir-Cit @gtsorbo @daniel-cit @amandakarina