Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set initial_node_count with remove_default_node_pool #1228

Merged
merged 1 commit into from
Apr 18, 2022
Merged

fix: set initial_node_count with remove_default_node_pool #1228

merged 1 commit into from
Apr 18, 2022

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Apr 15, 2022

Set initial_node_count to 1 if 0 supplied in safer-cluster inline with TPG documentation for the opinionated remove_default_node_pool=true.

@comment-bot-dev
Copy link

comment-bot-dev commented Apr 15, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody changed the title fix: enforce initial_node_count with remove_default_node_pool fix: set initial_node_count with remove_default_node_pool Apr 15, 2022
@apeabody apeabody marked this pull request as ready for review April 15, 2022 20:30
@apeabody apeabody requested review from a team, Jberlinsky and bharathkkb as code owners April 15, 2022 20:30
@apeabody apeabody requested a review from bharathkkb April 16, 2022 00:15
@bharathkkb bharathkkb merged commit 151c8c4 into terraform-google-modules:master Apr 18, 2022
@apeabody apeabody deleted the fix-patch-7 branch April 18, 2022 17:09
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants