Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set initial_node_count with remove_default_node_pool #1228

Merged
merged 1 commit into from
Apr 18, 2022
Merged

fix: set initial_node_count with remove_default_node_pool #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions autogen/safer-cluster/main.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@ module "gke" {

maintenance_start_time = var.maintenance_start_time

initial_node_count = var.initial_node_count

// We suggest removing the default node pool, as it cannot be modified without
// destroying the cluster.
remove_default_node_pool = true
// If removing the default node pool, initial_node_count should be at least 1.
initial_node_count = (var.initial_node_count == 0) ? 1 : var.initial_node_count

node_pools = var.node_pools
node_pools_labels = var.node_pools_labels
Expand Down
4 changes: 2 additions & 2 deletions modules/safer-cluster-update-variant/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ module "gke" {

maintenance_start_time = var.maintenance_start_time

initial_node_count = var.initial_node_count

// We suggest removing the default node pool, as it cannot be modified without
// destroying the cluster.
remove_default_node_pool = true
// If removing the default node pool, initial_node_count should be at least 1.
initial_node_count = (var.initial_node_count == 0) ? 1 : var.initial_node_count

node_pools = var.node_pools
node_pools_labels = var.node_pools_labels
Expand Down
4 changes: 2 additions & 2 deletions modules/safer-cluster/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ module "gke" {

maintenance_start_time = var.maintenance_start_time

initial_node_count = var.initial_node_count

// We suggest removing the default node pool, as it cannot be modified without
// destroying the cluster.
remove_default_node_pool = true
// If removing the default node pool, initial_node_count should be at least 1.
initial_node_count = (var.initial_node_count == 0) ? 1 : var.initial_node_count

node_pools = var.node_pools
node_pools_labels = var.node_pools_labels
Expand Down