fix: Update the format of "id" output in the "simple-sa" module #123
Conversation
Make the output "id" returning just a service account ID instead of the map with ID and an e-mail. There is already a separate output for the e-mail, called "email".
There was a problem hiding this comment.
Thanks for the contribution @legal90!
I think this is reasonable, however we'll need to mark as a breaking change. @legal90 could you add a (simple) docs/upgrading_to_v5.md migration guide similar to https://github.com/terraform-google-modules/terraform-google-service-accounts/blob/master/docs/upgrading_to_v3.md.
|
/gcbrun |
apeabody
changed the title
|
@apeabody Thank you! Should I just assume that a new 4.* release could be cut-off soon, before this PR is [potentially] merged? |
Thanks for pointing out @legal90 that we don't have a release with it yet! I'll make sure this PR is merged before the next release so we don't have to worry about a breaking change. |
apeabody
changed the title
Currently the output
idreturns a map containing both service account id and e-mail, which is misleading.There is already a separate output for the e-mail, called
email.So, in this PR I suggest to make the output
idreturning just a service account ID instead of the map.I didn't mark this change as a breaking change, because there was no release cut yet since the original implementation of "simple-sa" module was merged.