Skip to content

PSC Meeting Notes 2014 06 11

Marc Jansen edited this page Jun 12, 2014 · 6 revisions

Topics / Schedule

  1. Acceptance PSC Voting Process
  2. Regular virtual meetings
  3. Next Steps
  • 3.1 SHOGun
  • 3.2 SHOGun2
  1. TODOs

Participants

  • CM = @chrismayer
  • MJ = @marcjansen

Notes Taker

  • MJ, corrections by CM

Ad 1: Acceptance PSC Voting Process

Ad 2: Regular virtual meetings

  • We propose to make a biweekly virtual meeting (e.g. skype, google hangout whatever)
    • Voting:
      • MJ: +1
      • CM: +1
      • TA: +1
  • The meetings should be documented in this wiki (not the SHOGun2-wiki)
  • We shall make it easy to participate at the hangout by announicing it on the mailing-list(s) 24h before actually holding the meeting
  • If some topics are not fit for the general public we reserve the right to speak about these only with PSC-members

Ad 3.1: Next steps SHOGun

  • Current PRs
    • https://github.com/terrestris/shogun/pull/49 (LazyInitializationException Users-Modules)
      • Review will follow at the start of the next week.
      • Very important as main functionality isn't fully provided without this being merged (or something appropriate)
      • The PSC agrees that the review process of such a 'trivial'/'small' change is too hard and should be made easier
        • The reason is the currently 'unstructured' usage of various fetch-types
        • We need some sort of guideline here.
  • getAppContext
    • CM raises issue with security annotation (only non-anonymous user can call their AppContext) and missing real functionality (empty HashMap for 'app' being returned plus logged in user)
    • CM will create one or more PRs too change that method as outlined below
      • Secured for anon or higher
      • Hashmap 'app' will have the keys maplayers, mapcponfig & `modules
      • MJ agrees with the general structure of the above and is willing to provide a review
      • Blocked by #49
appDataMap.put("mapConfig", user.getMapConfig());
appDataMap.put("mapLayers", appMapLayers);
appDataMap.put("modules", appModules);
  • General state of current master
    • In order to make it easier to use SHOGun from scratch we plan on doing the following:
      • Release the state of SHOGun before merging the refactoring-branch as SHOGun 0.1
        • TODO: MJ
      • This will lead to the current state being actually really unstable because it isn't released
      • Based upon the changes proposed above (under 'getAppContext') we need a very basic mapclient
        • TODO: CM
      • This client shall live inside of the SHOGun project, not as a standalone, since we only will use the published resources of the base libraries

Ad 3.2: Next steps SHOGun2

  • Initial documention is there, can still be improved
  • A lot of work is going into the project by terrestris
  • How can we make it easier to allow participation?
  • Maybe a code sprint can help
  • MJ we still need to settle on a master-plan / general direction / architectural descicions
  • PR discussions postponed

TODO

  • SHOGun: Discuss possibility of GIS-Client donation by terrestris => TA
    • TA: Please specify what is meant - if the current GIS Client is wanted, that's OK after deleting some project-mattered functions. I have a list of project-unspecific functions.