Enhanced download functionality for yt-dlp unsupported links #363
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ] | ||
| ): | ||
| return False | ||
| if "www.instagram.com" in domain: |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
| return False | ||
| if "www.instagram.com" in domain: | ||
| return instagram(url, tempdir) | ||
| elif "pixeldrain.com" in domain: |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
| return xasiat(url, tempdir) | ||
|
|
||
|
|
||
| def sp_ytdl_download(url: str, tempdir: str): |
There was a problem hiding this comment.
the code in this function appears to be much duplicated comparing with the one in downloader.py. Anyway we can avoid those duplicates?
There was a problem hiding this comment.
Yes, It's the same function striped some parts. It would be great if we can call the function in downloader.py but I can't think of a way without it looping itself because some URLs(even tho it's direct URL) include domain parts used in handling function(sp_dl).
|
Sorry for the long delay. Generally speaking it seems okay, I will merge it to master in a day or two |
No worries at all; I completely understand that we're all busy with our lives. It's been my pleasure to contribute, even in a small way, to the development of a software that I use and enjoy every day. Thank you for considering my contribution. By the way, I still haven't been able to figure out that weird Instagram link bug. If possible, could you please take a look into it before merging? Your expertise might help resolve the issue. |
Moved
download_instagramfunction to new file calledsp_downloader.pythat now on handle all links that yt-dlp doesn’t support.Added pixeldrain.com as the first step.
yt-dlp version bump to new release 2024.03.10