Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced download functionality for yt-dlp unsupported links #363
Enhanced download functionality for yt-dlp unsupported links #363
Changes from all commits
7fc7667
6fe9cc2
35ce471
f31d29b
5ca5339
1ef601e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code in this function appears to be much duplicated comparing with the one in
downloader.py
. Anyway we can avoid those duplicates?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, It's the same function striped some parts. It would be great if we can call the function in
downloader.py
but I can't think of a way without it looping itself because some URLs(even tho it's direct URL) include domain parts used in handling function(sp_dl).